chore: make 'waitForCompletionTimeout' configurable with a flag#315
Merged
marc-brandenburg-form3 merged 1 commit intomasterfrom Sep 1, 2025
Merged
chore: make 'waitForCompletionTimeout' configurable with a flag#315marc-brandenburg-form3 merged 1 commit intomasterfrom
marc-brandenburg-form3 merged 1 commit intomasterfrom
Conversation
nvloff-f3
approved these changes
Sep 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the
waitForCompletionTimeoutvariable is hardcoded to 10 seconds, which prohibits the use of scenarios that take longer than 10 seconds.While it's not necessarily fitting the core problem statement of a load testing framework, there are cases where this tool can be used for scenarios that take more than the default 10 seconds.
This PR addresses this issue by making the timeout configurable with a command argument, still using the 10 seconds as a default.