Port all remaining required_table tests to rust
#586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Variable fonts that include a vmtx (vertical metrics) table should also include a VVAR table. As noted by Behdad (at notofonts/noto-cjk#307), inclusion of the VVAR table speeds up processing of vertical typesetting significantly with only a minor file size increase, even in cases where there is no variation in the vertical metrics (vmtx) across the designspace. Fonttools automatically adds this table if the vmtx table exists, and it isn't on the exclude list, but other build systems do not at present. (Closes fonttools#516)
Add unit tests for the missing-vvar warning in required_tables check: - test_vvar_missing: variable font with vmtx but no VVAR triggers WARN and message contains "vmtx" - test_vvar_present: variable font with vmtx AND VVAR has no warning Add ShantellSans test font to resources/test/ for VVAR present case. Remove equivalent Python tests in favor of Rust implementation.
- Add remove_table and add_table helpers to codetesting.rs - Port remaining Python tests for required_tables check - Tests cover TrueType, CFF, and CFF2 fonts - Tests validate required tables, optional tables detection, and VVAR check - Remove Python test file since Rust tests are now complete - Note: maxp removal test skipped as it causes TestFont initialization to fail
…lpers Replace raw byte manipulation in remove_table and add_table test helpers with skrifa FontRef and write-fonts FontBuilder APIs. This reduces code from ~110 lines each to ~15 lines while maintaining the same functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to PR #585 and it must only be reviewed after that one is merged.
And when doing so, feel free to git rebase against main branch.