feat(ui): highlight reverted breaking changes as a breaking change.#2055
Open
schilkp wants to merge 1 commit intofolke:mainfrom
Open
feat(ui): highlight reverted breaking changes as a breaking change.#2055schilkp wants to merge 1 commit intofolke:mainfrom
schilkp wants to merge 1 commit intofolke:mainfrom
Conversation
schilkp
force-pushed
the
schilkp/revert_breaking
branch
from
d1b85ab to
62d9512
Compare
schilkp
changed the title
schilkp
force-pushed
the
schilkp/revert_breaking
branch
from
62d9512 to
0efac74
Compare
schilkp
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A plugin I was using had a breaking change. I updated and adjusted my config as required. Some time later, the plugin reverted this commit again. I missed that when updating again because for said plugin the author is usually diligent about using conventional-commits for indicating breaking changes, so I did not read the changes too closely when I saw no breaking changes highlighted.
This updates the breaking-change detection regex to detect both commits of the form
feat!: ...andRevert "feat!: ...Related Issue(s)
None that I am aware of.
Screenshots
Without this change:
With this change:
