MODLD-939: Update the mapping of 019 #182
Conversation
pkjacob
force-pushed
the
pjacob/MODLD-939
branch
from
b4ba307 to
2fdd96b
Compare
There was a problem hiding this comment.
Pull request overview
This PR refactors the mapping configuration for MARC field 019 (OCLC Control Number) to use the NAME property instead of LOCAL_ID_VALUE, aligning it with other identifier field mappings and simplifying the configuration by using shared rules.
Key changes:
- Updated field 019 configuration to use shared identifier rules (similar to field 010)
- Replaced LOCAL_ID_VALUE property with NAME property across all affected files
- Updated test assertions to validate the new property mapping
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/main/resources/marc4ld.yml | Simplified field 019 mapping to use shared rules (current_instance_identifier and cancelled_instance_identifier) instead of verbose inline configuration; updated linking_entries_mappings to use NAME property for ID_LOCAL |
| src/main/resources/label.yml | Updated ID_LOCAL label rule to use NAME property instead of LOCAL_ID_VALUE |
| src/test/java/org/folio/marc4ld/test/helper/LinkingEntriesTestHelper.java | Updated test helper to validate "http://bibfra.me/vocab/lite/name" URL (consistent with other identifier types) |
| src/test/java/org/folio/marc4ld/mapper/test/MonographTestUtil.java | Removed LOCAL_ID_VALUE import and updated local identifier test data to use NAME property |
| src/test/java/org/folio/marc4ld/mapper/MarcBib2LdMapperIT.java | Removed LOCAL_ID_VALUE import and updated validation method to check NAME property instead |
| src/main/java/org/folio/marc4ld/service/marc2ld/authority/control/AuthorityIdentifierProcessorImpl.java | Added trailing newline (code style fix) |
| NEWS.md | Added changelog entry for the mapping update |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
NEWS.md
Outdated
| - Ensure only one MARC 100/110/111/130 is present in the derived MARC, converting any additional 1XX fields to 7XX [MODLD-934](https://folio-org.atlassian.net/browse/MODLD-934) | ||
| - Create MARC 600 when subject is a HUB [MODLD-538](https://folio-org.atlassian.net/browse/MODLD-538) | ||
| - Handle invalid place codes in MARC 26X [MODLD-949](https://folio-org.atlassian.net/browse/MODLD-949) | ||
| - Update the mapping of 019 to use NAME property instead of LOCAL_ID_VALUE property. |
There was a problem hiding this comment.
The NEWS.md entry is missing the JIRA ticket reference in the expected format. Based on the PR title "MODLD-939: Update the mapping of 019", this line should include the JIRA link like the other entries. It should be formatted as: "Update the mapping of 019 to use NAME property instead of LOCAL_ID_VALUE property MODLD-939"
zepheiryan
left a comment
zepheiryan
left a comment
There was a problem hiding this comment.
Copilot's NEWS.md review is relevant
pkjacob
force-pushed
the
pjacob/MODLD-939
branch
from
2fdd96b to
4d4c224
Compare
|
Build will pass after folio-org/lib-linked-data-fingerprint#97 is merged.
Related PRs:
folio-org/lib-linked-data-dictionary#132
folio-org/lib-linked-data-fingerprint#97
#182