Replace google_json_root_url with universe_domain

[stanhu]

This replaces the parameter introduced in #650.

universe_domain was introduced in googleapis/google-api-ruby-client#17131 and googleapis/google-auth-library-ruby#460.

This is preferable because the Google Client performs some verification to ensure credentials match the cloud provider.

[stanhu]

I'm still waiting for an environment to test this, but perhaps @Tchebychev you can give this a try?

[Copilot]

Pull request overview

This pull request replaces the google_json_root_url parameter (introduced in PR #650) with universe_domain, aligning with the Google API Ruby client library's native universe domain support. The change affects storage configuration and credential handling across Real and Mock implementations.

Changes:

• Replaced google_json_root_url parameter with universe_domain in storage configuration
• Added support for GOOGLE_CLOUD_UNIVERSE_DOMAIN environment variable
• Updated credential initialization to set universe_domain on Google Auth objects
• Modified URL construction to use universe domain for bucket base URLs

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File	Description
lib/fog/google/storage/storage_json.rb	Replaced google_json_root_url with universe_domain in recognized options
lib/fog/google/storage/storage_json/real.rb	Updated initialization to use universe domain for URL construction and set universe_domain on storage service
lib/fog/google/storage/storage_json/mock.rb	Added universe domain support to mock implementation with URL construction methods
lib/fog/google/shared.rb	Added universe_domain_from_options helper and updated credential processing to set universe_domain

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Tchebychev]

I'm still waiting for an environment to test this, but perhaps @Tchebychev you can give this a try?

I'll try to get someone on my team to test this.
Given our current workload, it might take a few days, so don't wait for me to release it if you want to make one.
The idea seems better than the one I proposed, so I'm okay with it in principle.

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[stanhu]

Released in v1.29.0.

[Tchebychev]

Thanks for the contribution ! Now Gitlab only needs to update the dependency so we can use this env var : https://gitlab.com/gitlab-org/gitlab/-/merge_requests/220951

[stanhu]

@Tchebychev The update is only one part of the equation. See https://gitlab.com/gitlab-org/gitlab/-/merge_requests/221401 and https://gitlab.com/gitlab-org/gitlab-runner/-/merge_requests/6338.

I can send you a test package if you want to try this out. We're still waiting for a test environment.

[geemus]

Thanks for continuing to work through this.