add support for installing system-level venv in ImageSpec#3400
Open
cosmicBboy wants to merge 1 commit intomasterfrom
Open
add support for installing system-level venv in ImageSpec#3400cosmicBboy wants to merge 1 commit intomasterfrom
cosmicBboy wants to merge 1 commit intomasterfrom
Conversation
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
cosmicBboy
requested review from
davidmirror-ops,
kumare3,
machichima,
pingsutw,
samhita-alla and
wild-endeavor
as code owners
| # When python_exec points to system Python (e.g. on NVIDIA base images), PEP 668 prevents | ||
| # installing packages directly. We create a venv using the base Python and install into it. | ||
| # --system-site-packages lets the venv see base image packages (e.g. NVIDIA TensorRT). | ||
| UV_PYTHON_VENV_INSTALL_COMMAND_TEMPLATE = Template( |
Contributor
There was a problem hiding this comment.
can we change the existing template instead of adding a new one?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue
Why are the changes needed?
What changes were proposed in this pull request?
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link