fix(actions): remove minimum length validation from state field

[SVilgelm]

Summary

• Remove min_len=2 validation constraint from the state field in UpdateRequest message in actions_service.proto
• The state field no longer enforces a minimum 2-character requirement, allowing empty state values

Test plan

• Verify proto compilation succeeds
• Verify actions service accepts empty state values in update requests

🤖 Generated with Claude Code

• main
  • Flyte 2 WIP #6583
    • fix(actions): remove minimum length validation from state field 👈

[Copilot]

Pull request overview

This PR appears to significantly restructure the repository’s deployment and build/release surface (Helm charts, Docker build, GitHub workflows), while also introducing new standalone services (Actions + Cache Service) and Buf-based protobuf generation configuration—despite the PR title/description referencing only a proto validation change.

Changes:

• Removes large portions of legacy Helm chart templates/values and various repo meta/docs/workflows.
• Adds new Go service modules (actions, cache_service) plus shared app helpers (k8s/db/errors/context).
• Introduces Buf v2 configuration and adds new GitHub workflows for regeneration and publishing generated artifacts (Rust/Python/TypeScript).

Reviewed changes

Copilot reviewed 1 out of 1 changed files in this pull request and generated 12 comments.

Show a summary per file

File	Description
charts/flyte-core/values-eks-override.yaml	Removes legacy Flyte core EKS override values (scheduler config).
charts/flyte-core/values-dataplane.yaml	Removes legacy dataplane values file.
charts/flyte-core/values-controlplane.yaml	Removes legacy controlplane values file.
charts/flyte-core/templates/propeller/webhook-hpa.yaml	Removes propeller webhook HPA template.
charts/flyte-core/templates/propeller/service.yaml	Removes propeller metrics Service template.
charts/flyte-core/templates/propeller/service-monitor.yaml	Removes propeller ServiceMonitor template.
charts/flyte-core/templates/propeller/rbac.yaml	Removes propeller RBAC templates.
charts/flyte-core/templates/propeller/manager.yaml	Removes propeller PodTemplate manager template.
charts/flyte-core/templates/propeller/crds/flyteworkflow.yaml	Removes FlyteWorkflow CRD template from flyte-core.
charts/flyte-core/templates/propeller/configmap.yaml	Removes propeller ConfigMap template.
charts/flyte-core/templates/flytescheduler/service.yaml	Removes flytescheduler Service template.
charts/flyte-core/templates/flytescheduler/service-monitor.yaml	Removes flytescheduler ServiceMonitor template.
charts/flyte-core/templates/flytescheduler/sa.yaml	Removes flytescheduler ServiceAccount template.
charts/flyte-core/templates/flytescheduler/configmap.yaml	Removes flytescheduler ConfigMap template.
charts/flyte-core/templates/datacatalog/service.yaml	Removes datacatalog Service template.
charts/flyte-core/templates/datacatalog/rbac.yaml	Removes datacatalog ServiceAccount template.
charts/flyte-core/templates/datacatalog/configmap.yaml	Removes datacatalog ConfigMap template.
charts/flyte-core/templates/console/service.yaml	Removes flyteconsole Service template.
charts/flyte-core/templates/console/service-monitor.yaml	Removes flyteconsole ServiceMonitor template.
charts/flyte-core/templates/console/deployment.yaml	Removes flyteconsole Deployment template.
charts/flyte-core/templates/console/configmap.yaml	Removes flyteconsole ConfigMap template.
charts/flyte-core/templates/common/secret.yaml	Removes common database secret manifest templating hook.
charts/flyte-core/templates/common/secret-auth.yaml	Removes auth secret template for admin OAuth client credentials.
charts/flyte-core/templates/common/namespace.yaml	Removes namespace template creation.
charts/flyte-core/templates/clusterresourcesync/deployment.yaml	Removes clusterresourcesync deployment template.
charts/flyte-core/templates/clusterresourcesync/configmap.yaml	Removes clusterresourcesync configmap template.
charts/flyte-core/templates/clusterresourcesync/cluster_resource_configmap.yaml	Removes cluster resource templates configmap.
charts/flyte-core/templates/admin/service.yaml	Removes flyteadmin Service template.
charts/flyte-core/templates/admin/service-monitor.yaml	Removes flyteadmin ServiceMonitor template.
charts/flyte-core/templates/admin/secret.yaml	Removes flyteadmin Secret template.
charts/flyte-core/templates/admin/rbac.yaml	Removes flyteadmin RBAC templates.
charts/flyte-core/templates/admin/configmap.yaml	Removes flyteadmin ConfigMaps templates.
charts/flyte-core/README.md.gotmpl	Removes flyte-core README template content.
charts/flyte-core/Chart.yaml	Removes flyte-core chart metadata (effectively removes chart definition).
charts/flyte-core/.helmignore	Removes flyte-core helm ignore file.
charts/flyte-binary/templates/service/webhook.yaml	Simplifies webhook Service: removes templated labels/annotations and changes targetPort behavior.
charts/flyte-binary/templates/service/http.yaml	Removes .Values.service.annotations from http Service annotations.
charts/flyte-binary/templates/service/grpc.yaml	Removes separate gRPC Service template.
charts/flyte-binary/templates/crds/flyteworkflow.yaml	Removes FlyteWorkflow CRD template from flyte-binary.
charts/flyte-binary/templates/clusterrole.yaml	Adjusts RBAC rules (API group/resource access changes) for flyte-binary.
charts/flyte-binary/templates/cluster-resource-templates.yaml	Removes cluster resource templates configmap template.
charts/flyte-binary/README.md	Updates chart version badge and updates co-pilot image tag documentation.
charts/flyte-binary/Chart.yaml	Updates chart version, removes appVersion/dependencies block from this snippet.
charts/event.json	Removes charts event metadata file.
cache_service/setup.go	Adds cache service setup: migrations, handler registration, readiness checks.
cache_service/repository/repository.go	Adds repository aggregator wiring for cache service persistence.
cache_service/repository/models/reservation.go	Adds Reservation model schema for cache service.
cache_service/repository/models/cached_output.go	Adds CachedOutput model schema for cache service.
cache_service/repository/interfaces/reservation.go	Adds ReservationRepo interface.
cache_service/repository/interfaces/repository.go	Adds Repository interface.
cache_service/repository/interfaces/cached_output.go	Adds CachedOutputRepo interface.
cache_service/repository/impl/reservation.go	Adds GORM-backed ReservationRepo implementation.
cache_service/repository/impl/cached_output.go	Adds GORM-backed CachedOutputRepo implementation.
cache_service/repository/errors/errors.go	Adds repository error helpers and claimability error.
cache_service/migrations/migrations.go	Adds gormigrate migrations for cache_service schema.
cache_service/manager/manager_test.go	Adds tests for cache service manager behavior (put/get + reservations).
cache_service/config/config.go	Adds cache_service config section (server + reservation heartbeat parameters).
cache_service/cmd/main.go	Adds standalone cache-service binary entrypoint.
buf.yaml	Adds Buf v2 module config + lint configuration.
buf.gen.ts.yaml	Adds Buf generation config for TypeScript outputs.
buf.gen.rust.yaml	Adds Buf generation config for Rust outputs.
buf.gen.python.yaml	Adds Buf generation config for Python outputs.
buf.gen.go.yaml	Adds Buf generation config for Go outputs (including gateway/openapi).
boilerplate/flyte/golang_test_targets/download_tooling.sh	Updates mockery version used in tooling download script.
assets/contributor-template.md	Removes contributor template used for README automation.
app/k8s.go	Adds shared Kubernetes client initialization helper (controller-runtime client).
app/error.go	Adds ServerError abstraction wrapping gRPC status + details.
app/db.go	Adds shared DB initialization helper.
app/context.go	Adds shared SetupContext for multi-service binaries (db/k8s/storage/mux/workers/ready checks).
actions/setup.go	Adds actions service setup: k8s client init, watcher lifecycle, handler registration.
actions/service/interfaces.go	Adds ActionsClientInterface definition.
actions/config/config.go	Adds actions service config section (server/k8s/watch settings).
actions/cmd/main.go	Adds standalone actions-service binary entrypoint.
SECURITY.md	Removes repository security policy document.
RELEASE.md	Removes repository release process document.
Dockerfile.flytescheduler	Removes legacy flytescheduler Dockerfile.
Dockerfile.flytepropeller	Removes legacy flytepropeller Dockerfile.
Dockerfile.flytecopilot	Removes legacy flytecopilot Dockerfile.
Dockerfile.flyteadmin	Removes legacy flyteadmin Dockerfile.
Dockerfile.datacatalog	Removes legacy datacatalog Dockerfile.
Dockerfile	Updates main build to Go 1.24 builder, changes build inputs and target binary build path.
CODE_OF_CONDUCT.md	Removes code of conduct doc.
CODEOWNERS	Replaces docs-specific owners with default owners + flyteidl2 directory owner rules.
CHANGELOG/README.md	Removes changelog README.
CHANGELOG/CHANGELOG-v1.7.0.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v1.6.1.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v1.6.0-b1.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v1.5.0-a0.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v1.4.3.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v1.4.2.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v1.4.1.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v1.4.0.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v1.4.0-b0.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v1.3.0-b9.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v1.3.0-b8.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v1.3.0-b7.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v1.3.0-b6.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v1.3.0-b4.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v1.3.0-b3.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v1.3.0-b2.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v1.3.0-b1.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v1.2.0.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v1.2.0-b5.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v1.2.0-b4.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v1.2.0-b3.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v1.2.0-b2.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v1.2.0-b1.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v1.16.0-b4.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v1.16.0-b3.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v1.16.0-b2.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v1.16.0-b1.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v1.15.3.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v1.15.2.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v1.14.1.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v1.13.1-rc1.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v1.13.0-rc0.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v1.12.1-rc0.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v1.11.1-b0.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v1.11.0.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v1.11.0-b1.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v1.11.0-b0.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v1.10.7-b4.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v1.10.7-b3.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v1.10.7-b2.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v1.10.7-b1.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v1.10.7-b0.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v1.10.6-b0.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v1.10.0-b0.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v1.1.0.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v1.1.0-b1.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v1.0.2.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v1.0.2-b2.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v1.0.2-b1.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v1.0.1.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v1.0.0.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v1.0.0-b1.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v0.9.0.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v0.8.0.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v0.7.0.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v0.6.0.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v0.5.0.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v0.4.0.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v0.3.0.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v0.2.0.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v0.19.4.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v0.19.3.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v0.19.3-b3.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v0.19.3-b2.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v0.19.3-b1.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v0.19.2.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v0.19.2-b5.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v0.19.2-b4.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v0.19.2-b3.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v0.19.2-b2.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v0.19.1.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v0.19.0.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v0.18.2.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v0.18.1.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v0.18.0.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v0.17.3.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v0.17.3-b4.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v0.17.3-b3.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v0.17.3-b2.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v0.17.3-b1.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v0.17.2.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v0.17.1.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v0.17.0.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v0.16.0.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v0.15.1.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v0.15.0.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v0.14.0.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v0.13.0.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v0.12.0.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v0.11.0.md	Removes legacy changelog entry.
CHANGELOG/CHANGELOG-v0.10.0.md	Removes legacy changelog entry.
.run/single-binary.run.xml	Removes IDE run configuration.
.readthedocs.yml	Removes ReadTheDocs build configuration.
.goreleaser.yml	Removes GoReleaser configuration.
.github/workflows/validate-helm-charts.yaml	Removes Helm chart validation workflow.
.github/workflows/upgrade_automation.yml	Removes boilerplate upgrade automation workflow.
.github/workflows/unit-tests.yml	Removes old reusable unit test workflow.
.github/workflows/tests.yml	Removes old aggregate test workflow.
.github/workflows/stale.yml	Removes stale issue/PR automation.
.github/workflows/sandbox.yml	Removes sandbox image build workflow.
.github/workflows/regenerate-on-comment.yml	Adds workflow to regenerate generated artifacts on PR comment command.
.github/workflows/publish.yml	Removes old reusable publish workflow.
.github/workflows/publish-rust.yml	Adds workflow to publish Rust crate on tag pushes.
.github/workflows/publish-python.yml	Adds workflow to publish Python package on tag pushes.
.github/workflows/publish-npm.yml	Adds workflow to publish TypeScript package on tag pushes.
.github/workflows/publish-images.yml	Removes workflow to publish component docker images.
.github/workflows/lint.yml	Removes old reusable lint workflow.
.github/workflows/integration.yml	Removes integration test workflow.
.github/workflows/helm-charts.yaml	Removes Helm packaging workflow.
.github/workflows/go_generate.yml	Removes old go generate check workflow.
.github/workflows/go-tests.yml	Adds new Go test matrix workflow with coverage artifact upload.
.github/workflows/git_town.yml	Adds Git Town workflow to display branch stacks.
.github/workflows/generate_flyte_manifest.yml	Removes manifest generation workflow.
.github/workflows/flyteidl-release.yml	Removes flyteidl release workflow.
.github/workflows/flyteidl-checks.yml	Removes flyteidl checks workflow.
.github/workflows/flyteidl-buf-publish.yml	Removes buf publish workflow for flyteidl.
.github/workflows/flytectl-release.yml	Removes flytectl release workflow.
.github/workflows/flytectl-install.yml	Removes flytectl install workflow.
.github/workflows/dependency-review.yml	Removes dependency review workflow.
.github/workflows/contributors.yaml	Removes contributor automation workflow.
.github/workflows/component_docker_build.yml	Removes component docker build workflow.
.github/workflows/codespell.yml	Removes codespell workflow.
.github/config.yml	Removes welcome-bot style configuration.
.github/codespell-ignored-words	Removes codespell ignore list.
.github/actions/setup-python-env/action.yml	Adds composite action for Python+uv environment setup with caching.
.github/actions/clear-action-cache/action.yml	Removes composite action for clearing runner disk usage.
.github/PULL_REQUEST_TEMPLATE.md	Adds PR template section for git-town stack display.
.github/ISSUE_TEMPLATE/ui_feature_request.yaml	Removes UI feature request issue template.
.github/ISSUE_TEMPLATE/housekeeping_template.yaml	Removes housekeeping issue template.
.github/ISSUE_TEMPLATE/flytectl_issue.yaml	Removes FlyteCTL feature request issue template.
.github/ISSUE_TEMPLATE/feature_request.yaml	Removes core feature request issue template.
.github/ISSUE_TEMPLATE/docs_issue.yaml	Removes docs issue template.
.github/ISSUE_TEMPLATE/bug_report.yaml	Removes bug report issue template.
.github/ISSUE_TEMPLATE/backend-plugin-request.yaml	Removes plugin request issue template.
.gitattributes	Removes linguist-generated file patterns.
.dockerignore	Expands dockerignore patterns; ignores generated outputs and common artifacts.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The PR title/description says it only removes min_len=2 validation from the state field in actions_service.proto, but this diff contains large-scale changes (Helm chart removals, new services, workflows, Docker/build changes) and I don't see the referenced proto change in the provided diff. Please update the PR title/description to match the actual scope, or split this into smaller PRs so the proto validation change can be reviewed/rolled back independently.

[Copilot]

This workflow runs on issue_comment and checks out the PR head, executes repo code (make gen-local) from that PR, and then pushes back using GITHUB_TOKEN with contents: write. This pattern is vulnerable to untrusted code execution and token exfiltration (any PR author can modify Makefiles/scripts that run here), and it also risks unintended writes to branches. Recommended fix: move regeneration to a trusted trigger (e.g., workflow_dispatch with an explicit ref by maintainers) or heavily restrict who can trigger (verify commenter association is MEMBER/OWNER, and avoid executing PR-provided code with write credentials).

Suggested change

	if: github.event.issue.pull_request && (contains(github.event.comment.body, '/regen') || contains(github.event.comment.body, ':repeat:')) && (github.event.comment.author_association == 'MEMBER' || github.event.comment.author_association == 'OWNER')

[Copilot]

This workflow runs on issue_comment and checks out the PR head, executes repo code (make gen-local) from that PR, and then pushes back using GITHUB_TOKEN with contents: write. This pattern is vulnerable to untrusted code execution and token exfiltration (any PR author can modify Makefiles/scripts that run here), and it also risks unintended writes to branches. Recommended fix: move regeneration to a trusted trigger (e.g., workflow_dispatch with an explicit ref by maintainers) or heavily restrict who can trigger (verify commenter association is MEMBER/OWNER, and avoid executing PR-provided code with write credentials).

[Copilot]

This workflow runs on issue_comment and checks out the PR head, executes repo code (make gen-local) from that PR, and then pushes back using GITHUB_TOKEN with contents: write. This pattern is vulnerable to untrusted code execution and token exfiltration (any PR author can modify Makefiles/scripts that run here), and it also risks unintended writes to branches. Recommended fix: move regeneration to a trusted trigger (e.g., workflow_dispatch with an explicit ref by maintainers) or heavily restrict who can trigger (verify commenter association is MEMBER/OWNER, and avoid executing PR-provided code with write credentials).

[Copilot]

This uses github.com/golang/protobuf/proto, but google.golang.org/grpc/status.WithDetails expects messages implementing google.golang.org/protobuf/proto.Message. Using the legacy proto package here is likely to cause type incompatibilities at compile time (or subtle runtime issues). Switch to google.golang.org/protobuf/proto for the proto.Message type used in this interface and implementation.

Suggested change

	"google.golang.org/protobuf/proto"

[Copilot]

The docstring says namespace creation is conditional on both Namespace being non-empty and Scheme being provided, but the code ensures the namespace whenever Namespace is non-empty (regardless of scheme). Update the comment to match behavior, or change the behavior to match the comment—otherwise this is misleading for callers.

[Copilot]

The phrase 'oppo bloom filter' looks like a typo and is unclear in user-facing flag help text. Consider changing it to something like 'approximate Bloom filter' or just 'Bloom filter'.

Suggested change

	RecordFilterSize int `json:"recordFilterSize" pflag:",Size of the Bloom filter for deduplicating RecordAction calls"`

[Copilot]

This change removes support for .Values.service.annotations on the HTTP Service while still supporting other annotation sources. If chart users already rely on service.annotations, their config will silently stop applying. If this is intentional, consider a deprecation path (support both keys for a while, or document the migration clearly) to avoid a breaking change in chart values.

Suggested change

	{{- end }}
	{{- if .Values.service.annotations }}
	{{- tpl ( .Values.service.annotations | toYaml ) . | nindent 4 }}
	{{- end }}

[Copilot]

Switching targetPort from a named port (e.g. webhook) to a hard-coded number (9443) makes the Service more brittle: it must now match the containerPort exactly and can drift if the deployment changes. Prefer using a named targetPort that matches the container port name, or ensure the deployment explicitly uses 9443 and keep the value configurable via chart values.

Suggested change

	targetPort: webhook

[Copilot]

Using http.DefaultClient for internal service-to-service calls means no request timeout by default, which can lead to hung goroutines and degraded service behavior under network partitions. Consider using an http.Client with a reasonable Timeout (and optionally transport tuning) for this internal client.