fix: always call writeOutput on connector SUCCEEDED#7135
Merged
Conversation
…ased outputs When a connector task succeeds but returns nil outputs (relying on file-based outputs written to remote storage), writeOutput was skipped entirely, leaving the BufferedOutputWriter without a reader. This caused ValidateOutput to fail with "Outputs not generated by task execution". Always call writeOutput on SUCCEEDED so the RemoteFileOutputReader fallback is used when outputs are nil, matching v1 behavior. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
pingsutw
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
writeOutputwas skipped entirely, leaving theBufferedOutputWriterwithout a readerValidateOutputto fail with "Outputs not generated by task execution"writeOutputonSUCCEEDEDso theRemoteFileOutputReaderfallback is used when outputs are nil, matching v1 behaviorTest plan
go test ./flyteplugins/go/tasks/plugins/webapi/connector/...)examples/basics/connectors.py) with executor-v2 and verify outputs are resolved correctly🤖 Generated with Claude Code
main