Skip to content

Add codespell config to v2 branch and fix detected typos#7121

Open
yarikoptic wants to merge 3 commits intoflyteorg:v2from
yarikoptic:enh-v2-codespell
Open

Add codespell config to v2 branch and fix detected typos#7121
yarikoptic wants to merge 3 commits intoflyteorg:v2from
yarikoptic:enh-v2-codespell

Conversation

@yarikoptic
Copy link
Copy Markdown
Contributor

@yarikoptic yarikoptic commented Mar 31, 2026

Cherry-pick codespell configuration from #7104 to v2 branch and fix typos detected in v2 code.

As requested in #7104 (comment).

Changes

Cherry-picked from master

  • 6cd20be Modernize codespell config: move from inline workflow to .codespellrc (#7104)

Typo fixes in flyteidl2

  • ThesesThese (actions/actions_service.proto)
  • inculdeinclude (gen_utils/rust/src/lib.rs)
  • ReponseResponse (workflow/run_logs_service.proto)
  • diferentdifferent (workflow/translator_service.proto)

Config update

  • Added */gen_utils/ts/* to .codespellrc skip (vendored Buf validate code)

Testing

Codespell passes with zero errors on the v2 branch after these changes.


🤖 Generated with Claude Code

@github-actions github-actions bot mentioned this pull request Mar 31, 2026
3 tasks
Copy link
Copy Markdown
Member

@pingsutw pingsutw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this, could you take a look at test errors

@pingsutw pingsutw added this to the V2 GA milestone Mar 31, 2026
@yarikoptic
Copy link
Copy Markdown
Contributor Author

some are likely due to me sending from fork? image

the others because I excluded gen (as "generated"?) from codespell fixes, and there those duplicated typos persist:

❯ git grep Reponse
gen/go/flyteidl2/workflow/run_logs_service.pb.go:// Reponse message for tailing logs.
gen/rust/src/flyteidl2.workflow.rs:/// Reponse message for tailing logs.
gen/ts/flyteidl2/workflow/run_logs_service_pb.ts: * Reponse message for tailing logs.

is there a consistent way to regenerate them or I should somehow strive to apply similar fixes to gen? here they (hopefully all) are:

❯ sed -i -e 's/,gen,/,/g' .codespellrc&& codespell
./gen/go/flyteidl2/actions/actions_service.pb.go:27: Theses ==> These, Thesis
./gen/go/flyteidl2/workflow/run_logs_service.pb.go:84: Reponse ==> Response
./gen/python/flyteidl2/workflow/translator_service_pb2_grpc.py:9: diferent ==> different
./gen/python/flyteidl2/workflow/translator_service_pb2_grpc.py:41: diferent ==> different
./gen/python/flyteidl2/workflow/translator_service_pb2_grpc.py:99: diferent ==> different
./gen/rust/src/flyteidl2.actions.rs:3: Theses ==> These, Thesis
./gen/rust/src/flyteidl2.workflow.rs:1117: Reponse ==> Response
./gen/rust/src/lib.rs:13: inculde ==> include
./gen/ts/buf/validate/validate_pb.ts:476: re-used ==> reused
./gen/ts/flyteidl2/actions/actions_service_pb.ts:25: Theses ==> These, Thesis
./gen/ts/flyteidl2/workflow/run_logs_service_pb.ts:49: Reponse ==> Response
./gen/ts/flyteidl2/workflow/translator_service_pb.ts:188: diferent ==> different

@pingsutw
Copy link
Copy Markdown
Member

pingsutw commented Apr 1, 2026

Could you run make gen locally and push the change?

@yarikoptic
Copy link
Copy Markdown
Contributor Author

eh, told me mom not to trust strangers (no offense!) ;) apparently docker is involved and I ended up with

❯ git diff
error: open("buf.lock"): Permission denied
fatal: cannot hash buf.lock
❯ ls -l buf.lock
-rw------- 1 root root 751 Apr  1 15:09 buf.lock
❯ find \! -uid $(id -u) -ls  | head
227735228      4 -rw-r--r--   1 root     root         1740 Apr  1 15:10 ./flytestdlib/cache/mocks/item.go
227735229      4 -rw-r--r--   1 root     root         1699 Apr  1 15:10 ./flytestdlib/cache/mocks/option.go
227733831      0 drwxr-xr-x   1 root     root         1690 Apr  1 15:09 ./gen/rust/src
227733832     64 -rw-r--r--   1 root     root        61979 Apr  1 15:09 ./gen/rust/src/flyteidl2.logs.dataplane.rs
227733833     36 -rw-r--r--   1 root     root        33354 Apr  1 15:09 ./gen/rust/src/flyteidl2.notification.rs
227733834    172 -rw-r--r--   1 root     root       173909 Apr  1 15:09 ./gen/rust/src/flyteidl2.org.rs
...

uff... ideally should switch to podman or singularity or other means to improve setup to avoid running as root for such trivial operations as regeneration. For now,

❯ ln -s /usr/bin/podman ~/bin/docker
❯ which -a docker
/home/yoh/bin/docker

then it behaved sane , I have pushed the result of that run, but I am not 100% sure it should be done as is as mixes in some other changes unrelated to typo fixes. So please review/advise.

yarikoptic and others added 3 commits April 1, 2026 15:23
…flyteorg#7104)

Signed-off-by: Yaroslav Halchenko <debian@onerussian.com>
Co-authored-by: Claude Code 2.1.81 / Claude Opus 4.6 <noreply@anthropic.com>

Conflicts:
	.github/workflows/codespell.yml -- removed in this branch
Signed-off-by: Yaroslav Halchenko <debian@onerussian.com>
As requested in flyteorg#7104 (comment)

Fixed typos:
- Theses -> These (actions_service.proto)
- inculde -> include (gen_utils/rust/src/lib.rs)
- Reponse -> Response (run_logs_service.proto)
- diferent -> different (translator_service.proto)

Also skip vendored gen_utils/ts/ (buf validate code) in .codespellrc.

Co-Authored-By: Claude Code 2.1.81 / Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Yaroslav Halchenko <debian@onerussian.com>
=== Do not change lines below ===
{
 "chain": [],
 "cmd": "make gen",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^

Signed-off-by: Yaroslav Halchenko <debian@onerussian.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants