Add codespell config to v2 branch and fix detected typos#7121
Add codespell config to v2 branch and fix detected typos#7121yarikoptic wants to merge 3 commits intoflyteorg:v2from
Conversation
pingsutw
left a comment
There was a problem hiding this comment.
Thanks for adding this, could you take a look at test errors
|
the others because I excluded is there a consistent way to regenerate them or I should somehow strive to apply similar fixes to gen? here they (hopefully all) are: |
|
Could you run |
|
eh, told me mom not to trust strangers (no offense!) ;) apparently docker is involved and I ended up with ❯ git diff
error: open("buf.lock"): Permission denied
fatal: cannot hash buf.lock
❯ ls -l buf.lock
-rw------- 1 root root 751 Apr 1 15:09 buf.lock
❯ find \! -uid $(id -u) -ls | head
227735228 4 -rw-r--r-- 1 root root 1740 Apr 1 15:10 ./flytestdlib/cache/mocks/item.go
227735229 4 -rw-r--r-- 1 root root 1699 Apr 1 15:10 ./flytestdlib/cache/mocks/option.go
227733831 0 drwxr-xr-x 1 root root 1690 Apr 1 15:09 ./gen/rust/src
227733832 64 -rw-r--r-- 1 root root 61979 Apr 1 15:09 ./gen/rust/src/flyteidl2.logs.dataplane.rs
227733833 36 -rw-r--r-- 1 root root 33354 Apr 1 15:09 ./gen/rust/src/flyteidl2.notification.rs
227733834 172 -rw-r--r-- 1 root root 173909 Apr 1 15:09 ./gen/rust/src/flyteidl2.org.rs
...uff... ideally should switch to podman or singularity or other means to improve setup to avoid running as root for such trivial operations as regeneration. For now, then it behaved sane , I have pushed the result of that run, but I am not 100% sure it should be done as is as mixes in some other changes unrelated to typo fixes. So please review/advise. |
…flyteorg#7104) Signed-off-by: Yaroslav Halchenko <debian@onerussian.com> Co-authored-by: Claude Code 2.1.81 / Claude Opus 4.6 <noreply@anthropic.com> Conflicts: .github/workflows/codespell.yml -- removed in this branch Signed-off-by: Yaroslav Halchenko <debian@onerussian.com>
As requested in flyteorg#7104 (comment) Fixed typos: - Theses -> These (actions_service.proto) - inculde -> include (gen_utils/rust/src/lib.rs) - Reponse -> Response (run_logs_service.proto) - diferent -> different (translator_service.proto) Also skip vendored gen_utils/ts/ (buf validate code) in .codespellrc. Co-Authored-By: Claude Code 2.1.81 / Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Yaroslav Halchenko <debian@onerussian.com>
=== Do not change lines below ===
{
"chain": [],
"cmd": "make gen",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
Signed-off-by: Yaroslav Halchenko <debian@onerussian.com>
6cb35ba to
fa78b7a
Compare

Cherry-pick codespell configuration from #7104 to v2 branch and fix typos detected in v2 code.
As requested in #7104 (comment).
Changes
Cherry-picked from master
Modernize codespell config: move from inline workflow to .codespellrc (#7104)Typo fixes in flyteidl2
Theses→These(actions/actions_service.proto)inculde→include(gen_utils/rust/src/lib.rs)Reponse→Response(workflow/run_logs_service.proto)diferent→different(workflow/translator_service.proto)Config update
*/gen_utils/ts/*to.codespellrcskip (vendored Buf validate code)Testing
Codespell passes with zero errors on the v2 branch after these changes.
🤖 Generated with Claude Code
main