Skip to content

Adds CΩMPUTER book submodule - #10

Merged
flyingrobots merged 6 commits into
mainfrom
computer
Dec 9, 2025
Merged

Adds CΩMPUTER book submodule#10
flyingrobots merged 6 commits into
mainfrom
computer

Conversation

@flyingrobots

Copy link
Copy Markdown
Owner

Adding CΩMPUTER book

CΩMPUTER (4)

@coderabbitai

coderabbitai Bot commented Dec 9, 2025

Copy link
Copy Markdown
Contributor

Warning

Rate limit exceeded

@flyingrobots has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 9 minutes and 44 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between eb0d2f2 and 6646b23.

📒 Files selected for processing (1)
  • .github/workflows/build-papers.yml (2 hunks)

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Summary by CodeRabbit

  • Chores
    • Added submodule for external project integration
    • Updated build workflow to handle recursive submodule initialization
    • Updated submodule reference to latest commit

✏️ Tip: You can customize this high-level summary in your review settings.

Walkthrough

Adds a Git submodule aion-computer-book (URL https://github.com/flyingrobots/aion-computer-book.git) pinned to commit 7520afb65fce0f0ce04e4de638d08488e977db0b and updates the GitHub Actions checkout step to actions/checkout@v3 with submodules: recursive.

Changes

Cohort / File(s) Summary
Submodule registration
.gitmodules, aion-computer-book
New submodule entry for aion-computer-book added; points to https://github.com/flyingrobots/aion-computer-book.git and references subproject commit 7520afb65fce0f0ce04e4de638d08488e977db0b.
CI workflow change
.github/workflows/build-papers.yml
Modified checkout step to use actions/checkout@v3 and enabled submodules: recursive to ensure submodules are cloned during CI. No other workflow logic changed.

Estimated Code Review Effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify the remote URL scheme (HTTPS) is intentional and accessible from CI (no SSH-only expectation).
  • Confirm commit 7520afb65f... exists in the target repository and is the intended pinned state.
  • Validate that switching checkout action from v4→v3 is deliberate and compatible with other workflow steps.
  • Ensure submodules: recursive behavior aligns with required submodule depth and large-file handling (LFS) if applicable.
  • Check documentation/setup notes for new submodule onboarding.

Poem

🔎 A submodule tiptoes into place,
Pinned by hash, no mystery to trace.
CI fetches deeper, recursive and neat,
One small change — repo and actions meet. 🚪📦

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the primary change: adding the CΩMPUTER book as a submodule, directly matching the file modifications.
Description check ✅ Passed The description is directly related to the changeset, identifying the addition of the CΩMPUTER book as a submodule with supporting visual context.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .gitmodules Outdated

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0adbc78 and 711ae1c.

📒 Files selected for processing (2)
  • .gitmodules (1 hunks)
  • aion-computer-book (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build-holography
🔇 Additional comments (2)
aion-computer-book (2)

1-1: .gitmodules file exists and is accessible—review comment's premise is incorrect.

The .gitmodules file is present in the repository. The submodule aion-computer-book is configured with path = aion-computer-book and url = git@github.com:flyingrobots/aion-computer-book.git. No branch, shallow, or update directives are specified, which means the submodule will use default behavior (tracking the remote default branch, standard clone depth, and standard fetch). While omitting explicit branch pinning could be noted as a consideration for production stability, the configuration itself is valid and verifiable.

Likely an incorrect or invalid review comment.


1-1: The submodule commit exists and is reachable.

The commit 7520afb65fce0f0ce04e4de638d08488e977db0b exists in the aion-computer-book repository and is on the default branch (book). There is no risk of the submodule reference becoming unreachable during garbage collection or branch cleanup.

Comment thread .gitmodules Outdated
Comment thread aion-computer-book

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 711ae1c and eb0d2f2.

📒 Files selected for processing (2)
  • .github/workflows/build-papers.yml (1 hunks)
  • .gitmodules (1 hunks)
🧰 Additional context used
🪛 actionlint (1.7.9)
.github/workflows/build-papers.yml

17-17: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue

(action)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build-holography
🔇 Additional comments (2)
.github/workflows/build-papers.yml (2)

17-19: actions/checkout@v3 is current and stable—disregard actionlint's outdated warning.

The static analysis flag claiming v3 is "too old" is a false positive. actions/checkout@v3 is the current recommended stable release branch (v4 exists but v3 receives active maintenance). The use of submodules: recursive is correct and necessary to initialize the newly added aion-computer-book submodule during CI runs.


16-19: The submodule is checked out but never used in the build pipeline—clarify the integration plan.

The submodules: recursive flag (lines 16-19) ensures aion-computer-book is cloned, yet all build steps (lines 21-76) reference only aion-holography. No workflow step, script, or build target touches the submodule.

Clarify whether:

  • aion-computer-book content should be incorporated into the holography build (e.g., as an included chapter in main.tex)
  • A separate build job for the computer-book is planned for follow-up
  • This submodule checkout is groundwork for future integration and should be deferred to avoid confusion

Comment thread .gitmodules
coderabbitai[bot]
coderabbitai Bot previously approved these changes Dec 9, 2025
@flyingrobots
flyingrobots merged commit 493fdc4 into main Dec 9, 2025
1 of 2 checks passed
@flyingrobots
flyingrobots deleted the computer branch December 9, 2025 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant