mailman: do not require nginx uwsgiPass option#1116
Merged
leona-ya merged 1 commit intonixos-25.05from Nov 4, 2025
Merged
Conversation
Partial revert of d1a28bb Reason: In fc-nixos, the services.nginx module is shadowed by a vendored nginx base-module.nix, so changes (and reverts) in this nixpkgs fork repository do not have any effect. That vendored base-module is too old though to have the `uwsgiPass` option. `services.mailman` is the only module as of now relying on that option, so we revert it back to work with the older style nginx module. This is a stop-gap solution only applied to the 25.05 nixpkgs branch, as we finally adapt the current `services.nginx` module in fc-nixos-25.11. PL-133981
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
leona-ya
approved these changes
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial revert of d1a28bb
Reason:
In fc-nixos, the services.nginx module is shadowed by a vendored nginx base-module.nix, so changes (and reverts) in this nixpkgs fork repository do not have any effect.
That vendored base-module is too old though to have the
uwsgiPassoption.services.mailmanis the only module as of now relying on that option, so we revert it back to work with the older style nginx module.This is a stop-gap solution only applied to the 25.05 nixpkgs branch, as we finally adapt the current
services.nginxmodule in fc-nixos-25.11.PL-133981
tested: