Skip to content

fc-collect-garbage: Warn about unknown/human users with gcroots#2166

Open
dhnasa wants to merge 1 commit intofc-25.11-devfrom
PL-134227-human-user-gcroots-2511
Open

fc-collect-garbage: Warn about unknown/human users with gcroots#2166
dhnasa wants to merge 1 commit intofc-25.11-devfrom
PL-134227-human-user-gcroots-2511

Conversation

@dhnasa
Copy link

@dhnasa dhnasa commented Feb 9, 2026

@flyingcircusio/release-managers

PL-134227

Release process

  • Created changelog entry using ./changelog.sh

PR release workflow (internal)

  • PR has internal ticket
  • internal issue ID (PL-…) part of branch name
  • internal issue ID mentioned in PR description text
  • ticket is on Platform agile board
  • if ticket is more urgent than within the next few days, directly contact a member of the Platform team
  • set urgency and risk labels
  • ensure the merge bot has determined a merge date
  • ensure all checks are green
  • get a review from a colleague

Design notes

  • Provide a feature toggle if the change might need to be adjusted/reverted quickly depending on context. Consider whether the default should be on or off. Example: rate limiting.
  • All customer-facing features and (NixOS) options need to be discoverable from documentation. Add or update relevant documentation such that hosted and guided customers can understand it as well.

Security implications

@dhnasa dhnasa added risk: 1 very low risk urgency: 1 very low urgency labels Feb 9, 2026
@dhnasa dhnasa requested a review from chrschm February 9, 2026 14:29
Copy link
Member

@ctheune ctheune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, two adjustments please :)



def check():
human_usernames = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently KNOWN users can be reliably as human by checking for membership of GID 100 (users)

if not roots:
continue
users_with_roots += 1
print(f"Found {len(roots)} gcroots for unknown/human user {username}")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets help the humans who need to consume this message: explicitly say whether this is an unknown or human user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk: 1 very low risk urgency: 1 very low urgency

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants