fc-collect-garbage: Warn about unknown/human users with gcroots#2166
Open
dhnasa wants to merge 1 commit intofc-25.11-devfrom
Open
fc-collect-garbage: Warn about unknown/human users with gcroots#2166dhnasa wants to merge 1 commit intofc-25.11-devfrom
dhnasa wants to merge 1 commit intofc-25.11-devfrom
Conversation
ctheune
requested changes
Feb 18, 2026
Member
ctheune
left a comment
There was a problem hiding this comment.
looks good, two adjustments please :)
|
|
||
|
|
||
| def check(): | ||
| human_usernames = { |
Member
There was a problem hiding this comment.
currently KNOWN users can be reliably as human by checking for membership of GID 100 (users)
| if not roots: | ||
| continue | ||
| users_with_roots += 1 | ||
| print(f"Found {len(roots)} gcroots for unknown/human user {username}") |
Member
There was a problem hiding this comment.
lets help the humans who need to consume this message: explicitly say whether this is an unknown or human user.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@flyingcircusio/release-managers
PL-134227
Release process
./changelog.shPR release workflow (internal)
Design notes
onoroff. Example: rate limiting.Security implications