Skip to content

Support non-root flavor-based configuration file discovery #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
m-sadegh-sh wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support non-root flavor-based configuration file discovery #664

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions lib/main.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,11 @@ const String prefixOption = 'prefix';
const String defaultConfigFile = 'flutter_launcher_icons.yaml';
const String flavorConfigFilePattern = r'^flutter_launcher_icons-(.*).yaml$';

Future<List<String>> getFlavors() async {
Future<List<String>> getFlavors({String searchPath = '.'}) async {
final List<String> flavors = [];
await for (var item in Directory('.').list()) {

// Recursively search through directories
await for (var item in Directory(searchPath).list(recursive: true)) {
if (item is File) {
final name = path.basename(item.path);
final match = RegExp(flavorConfigFilePattern).firstMatch(name);
Expand All @@ -37,6 +39,7 @@ Future<List<String>> getFlavors() async {
return flavors;
}


Future<void> createIconsFromArguments(List<String> arguments) async {
final ArgParser parser = ArgParser(allowTrailingOptions: true);
parser
Expand All @@ -54,6 +57,11 @@ Future<void> createIconsFromArguments(List<String> arguments) async {
abbr: 'p',
help: 'Generates config in the given path. Only Supports web platform',
defaultsTo: '.',
)
..addOption(
'flavor-path',
help: 'Path to search for flavor configuration files',
defaultsTo: '.',
);

final ArgResults argResults = parser.parse(arguments);
Expand All @@ -69,7 +77,7 @@ Future<void> createIconsFromArguments(List<String> arguments) async {
}

// Flavors management
final flavors = await getFlavors();
final flavors = await getFlavors(searchPath: argResults['flavor-path']);
final hasFlavors = flavors.isNotEmpty;

final String prefixPath = argResults[prefixOption];
Expand Down