chore: clean unused code

[TrafalgarZZZ]

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fixes #XXXX

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

[gemini-code-assist]

Summary of Changes

Hello @TrafalgarZZZ, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing code maintainability and reducing redundancy through a targeted cleanup effort. It involves the removal of several functions that were identified as unused, specifically those related to retrieving Fuse and Worker node information. Additionally, resource comparison logic within JindoCache tests has been standardized by adopting an existing utility function, thereby eliminating duplicate code. This change streamlines the codebase without altering core functionality.

Highlights

• Code Removal: Removed unused GetFuseNodes and GetIpAddressesOfFuse functions from pkg/ctrl/fuse.go.
• Code Removal and Import Cleanup: Removed unused GetWorkerNodes and GetIpAddressesOfWorker functions from pkg/ctrl/worker.go, along with the associated k8s.io/apimachinery/pkg/labels import.
• Refactoring and Standardization: Refactored resource comparison logic in pkg/ddc/jindocache/transform_test.go to utilize a shared utility function (utils.ResourceRequirementsEqual), eliminating redundant local implementations.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively cleans up the codebase by removing unused functions in pkg/ctrl/fuse.go and pkg/ctrl/worker.go, along with an unused import. It also refactors duplicated resource comparison logic from pkg/ddc/jindocache/transform_test.go into the shared pkg/utils package, which is a good improvement for maintainability. The changes are correct and beneficial. I approve this pull request.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.57%. Comparing base (21052b3) to head (736221a).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5393      +/-   ##
==========================================
+ Coverage   57.42%   57.57%   +0.14%     
==========================================
  Files         443      443              
  Lines       30796    30706      -90     
==========================================
- Hits        17686    17678       -8     
+ Misses      11499    11418      -81     
+ Partials     1611     1610       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

Pull request overview

This PR removes unused code across multiple packages to improve code maintainability. The cleanup includes removing unused functions related to IP address retrieval, node operations, and test helper functions that have been consolidated into shared utility functions.

Key Changes:

• Removed unused IP address and node retrieval functions from pkg/utils/kubeclient
• Consolidated resource comparison helper functions by using shared utilities in pkg/utils
• Cleaned up unused import statements across multiple files

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
pkg/utils/kubeclient/pod.go	Removed unused GetIpAddressesOfPods function
pkg/utils/kubeclient/node.go	Removed unused GetIpAddressesOfNodes function and utils import
pkg/utils/kubeclient/node_test.go	Removed test for deleted function and unused reflect import
pkg/ddc/jindocache/transform_test.go	Removed duplicate helper functions and switched to using utils.ResourceRequirementsEqual
pkg/ctrl/worker.go	Removed unused GetWorkerNodes and GetIpAddressesOfWorker functions and labels import
pkg/ctrl/fuse.go	Removed unused GetFuseNodes and GetIpAddressesOfFuse functions

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[RongGu]

/lgtm
/approve

[fluid-e2e-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RongGu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [RongGu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment