feat(fluentbit): adds support for workers to syslog output - #1874
Merged
joshuabaird merged 6 commits intoMay 6, 2026
Conversation
joshuabaird
reviewed
Feb 17, 2026
Collaborator
|
@mob-galtryn Would you mind taking a look at tests for other output plugins (eg, datadog, gelf, s3) and implement tests for the syslog output plugin in a similar fashion? Thanks! |
Contributor
Author
|
@joshuabaird I have found tests here apis/fluentbit/v1alpha2/clusteroutput_types_test.go that includes tests for the syslog output, are these the tests you are referring to? |
joshuabaird
changed the title
joshuabaird
changed the title
Collaborator
Tests would probably go in a new |
Contributor
|
@joshuabaird could you please review if the test is ok? |
marcofranssen
force-pushed
the
adds-support-for-workers-syslog
branch
from
April 2, 2026 07:08
02696c4 to
be41f22
Compare
Collaborator
|
@Cajga the CI is failing |
Member
|
please resolve the merge conflicts in this pull request |
Collaborator
|
@copilot resolve the merge conflicts in this pull request |
Signed-off-by: Nick Galtry <nick.galtry@mobilise.cloud>
Signed-off-by: Nick Galtry <nick.galtry@mobilise.cloud>
Signed-off-by: Nick Galtry <nick.galtry@mobilise.cloud>
- Fix `workers` -> `Workers` (exported field) in syslog_types_test.go - Regenerate CRD manifests via make manifests; previous commits incorrectly targeted charts/fluent-bit-crds/ (non-existent), now correctly written to charts/fluent-operator-fluent-bit-crds/templates/ Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Josh Baird <jbaird@galileo.io>
joshuabaird
force-pushed
the
adds-support-for-workers-syslog
branch
from
May 6, 2026 13:33
d472d06 to
a6cdc52
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for configuring Fluent Bit syslog output plugin workers via Fluent Operator’s CRDs, ensuring the setting is rendered into the generated Fluent Bit configuration and documented for users.
Changes:
- Add
workersto the Syslog output plugin API type and render it into output params. - Regenerate/update CRD schemas and installation manifests to expose
spec.syslog.workers. - Update syslog output plugin documentation and add a unit test for params rendering.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| manifests/setup/setup.yaml | Exposes workers in the rendered installation manifest CRDs for syslog output. |
| manifests/setup/fluent-operator-crd.yaml | Mirrors the workers schema change in the operator CRD bundle manifest. |
| docs/plugins/fluentbit/output/syslog.md | Documents the new workers field for syslog output. |
| config/crd/bases/fluentbit.fluent.io_outputs.yaml | Adds workers to the syslog output schema in the base CRD. |
| config/crd/bases/fluentbit.fluent.io_clusteroutputs.yaml | Adds workers to the syslog clusteroutput schema in the base CRD. |
| charts/fluent-operator/crds/fluentbit.fluent.io_outputs.yaml | Updates Helm CRDs to include the syslog workers field. |
| charts/fluent-operator/crds/fluentbit.fluent.io_clusteroutputs.yaml | Updates Helm CRDs to include the syslog workers field for clusteroutputs. |
| charts/fluent-operator-fluent-bit-crds/templates/fluentbit.fluent.io_outputs.yaml | Updates Fluent Bit CRD chart templates with the syslog workers field. |
| charts/fluent-operator-fluent-bit-crds/templates/fluentbit.fluent.io_clusteroutputs.yaml | Updates Fluent Bit clusteroutput CRD chart templates with the syslog workers field. |
| apis/fluentbit/v1alpha2/plugins/output/syslog_types.go | Adds Workers to the Syslog type and inserts workers into rendered params. |
| apis/fluentbit/v1alpha2/plugins/output/syslog_types_test.go | Adds a unit test validating workers is included in rendered syslog params. |
- Run make generate to add Workers *int32 deepcopy to zz_generated.deepcopy.go - Remove conversational inline comments from syslog_types_test.go Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Josh Baird <jbaird@galileo.io>
joshuabaird
approved these changes
May 6, 2026
This was referenced May 21, 2026
4 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nick Galtry nick.galtry@mobilise.cloud
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1870
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: