Skip to content

update link checker test#2408

Merged
alexakreizinger merged 2 commits intomasterfrom
update-link-checker-test
Mar 3, 2026
Merged

update link checker test#2408
alexakreizinger merged 2 commits intomasterfrom
update-link-checker-test

Conversation

@alexakreizinger
Copy link
Member

@alexakreizinger alexakreizinger commented Mar 3, 2026

this updates the link checker test to ignore 401, 403, and 429 error codes. (the other values in that argument are part of the link checker's default value.)

401 and 403 are ostensibly auth errors, but it seems like some non-auth pages return those statuses as an anti-scraper thing when the check runs--and even if they were genuine 401 or 403 errors, those don't indicate a broken link, just something that requires login. 429 also seems like an anti-scraper defense mechanism. in any case, they're not 404 errors or other status that indicate a genuine broken link :)

Summary by CodeRabbit

  • Chores
    • Updated link checker workflow to accept a broader range of HTTP status codes (including informational and additional success/error codes), enable verbose output, disable progress display, and run from the workflow root for clearer, more comprehensive link validation.

Signed-off-by: Alexa Kreizinger <[email protected]>
@alexakreizinger alexakreizinger requested review from a team and eschabell as code owners March 3, 2026 20:52
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4de679f and bd0e43c.

📒 Files selected for processing (1)
  • .github/workflows/linkcheck.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/linkcheck.yaml

📝 Walkthrough

Walkthrough

Updates the Lychee link-checker invocation in the GitHub Actions workflow to pass explicit CLI arguments: expand allowed HTTP status codes (100..=103, 200..=299, 401, 403, 429), enable verbose output, disable progress display, and set the working directory to the workflow root (trailing dot).

Changes

Cohort / File(s) Summary
GitHub Actions workflow
.github/workflows/linkcheck.yaml
Added args to the Lychee Action to: accept additional HTTP status codes (100..=103, 200..=299, 401, 403, 429), enable --verbose, disable progress with --no-progress, and set working directory via trailing .. No other logic changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested reviewers

  • eschabell
  • esmerel

Poem

🐰 I hop the links both near and far,
Verbose I sing beneath each star,
Wider codes I kindly greet,
No progress bar beneath my feet,
Rooted here — the workflow's neat! 🥕✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'update link checker test' is vague and generic, using non-descriptive terms that don't convey the actual change being made to the link checker configuration. Revise the title to be more specific about what is being updated, such as 'Configure link checker to ignore auth and rate-limit status codes' or similar.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch update-link-checker-test

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/linkcheck.yaml:
- Line 23: The workflow step using the args string currently targets
'./**/*.mdx' which matches no files; update the glob in that args value (the
string passed to the linkcheck action) to include Markdown files, e.g. replace
'./**/*.mdx' with a glob that matches .md (and optionally .mdx) such as
'./**/*.md' or './**/*.{md,mdx}', keeping the existing --accept flags and other
options intact so link checking runs again.

ℹ️ Review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 48b7979 and 4de679f.

📒 Files selected for processing (1)
  • .github/workflows/linkcheck.yaml

Signed-off-by: Alexa Kreizinger <[email protected]>
@alexakreizinger alexakreizinger merged commit 26b9972 into master Mar 3, 2026
6 checks passed
@alexakreizinger alexakreizinger deleted the update-link-checker-test branch March 3, 2026 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants