API feature: Get minimum/maximum length of a possible match#14
Open
karalus wants to merge 1 commit intoflorianingerl:masterfrom
Open
API feature: Get minimum/maximum length of a possible match#14karalus wants to merge 1 commit intoflorianingerl:masterfrom
karalus wants to merge 1 commit intoflorianingerl:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would appreciate this amendment of the API because it can make my code cleaner, i.e. I can do without using reflection for accessing package protected functionality. Look at my Hack
It is also helping to gain better performance in some scenarios:
If you know in advance that a string cannot match the Pattern because it is not matching the minLength/maxLenght, you can go without creating a Matcher-instance saving memory and CPU.