Skip to content

FXC-4346 Base flux and dot calculations on non-colocated fields when possible #3100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
dmarek-flex wants to merge 18 commits into
base: develop
Choose a base branch
from
Draft

FXC-4346 Base flux and dot calculations on non-colocated fields when possible #3100

dmarek-flex wants to merge 18 commits into from

Conversation

@dmarek-flex
Copy link
Contributor

@dmarek-flex dmarek-flex commented Dec 16, 2025 •
edited
Loading

backend PR

List of additional changes:

  • Modes normalized in ModeMonitor and ModeSolverData based on conjugated or non-conjugated self-overlap (no longer strictly the flux). However, ModeSource will be normalized by flux to give 1W time averaged-power regardless of conjugation choice

@dmarek-flex dmarek-flex self-assigned this Dec 16, 2025
@dmarek-flex dmarek-flex force-pushed the dmarek/FXC-4346-Base-flux-and-dot-calculations-on-non-colocated-fields branch from b4f9377 to 0f29a2d Compare December 16, 2025 21:33
@dmarek-flex
fix(mode): change flux and dot methods to avoid interpolation when po…
71f806a 
…ssible

more care truncating cells at monitor boundary

fix source/monitor flux agreement
@dmarek-flex
combining mode solver and monitor data dot calcs
e9d8445
@dmarek-flex dmarek-flex force-pushed the dmarek/FXC-4346-Base-flux-and-dot-calculations-on-non-colocated-fields branch from 0f29a2d to e9d8445 Compare December 23, 2025 15:37
@dmarek-flex dmarek-flex requested a review from caseyflex January 13, 2026 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@caseyflex caseyflex Awaiting requested review from caseyflex caseyflex is a code owner

@weiliangjin2021 weiliangjin2021 Awaiting requested review from weiliangjin2021 weiliangjin2021 will be requested when the pull request is marked ready for review weiliangjin2021 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@dmarek-flex dmarek-flex

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dmarek-flex