Skip to content

Change .MakeMKV from filesystem to persist#101

Open
nalsai wants to merge 1 commit intoflathub:masterfrom
nalsai:master
Open

Change .MakeMKV from filesystem to persist#101
nalsai wants to merge 1 commit intoflathub:masterfrom
nalsai:master

Conversation

@nalsai
Copy link
Copy Markdown

@nalsai nalsai commented Jan 6, 2025

Moves the internal settings to the proper path (~/.var/app/com.makemkv.MakeMKV/.MakeMKV) as MakeMKV does not follow the XDG Base Directory specification.

This addresses the second point of #32 as best as possible without being able to change the MakeMKV source code

@flathubbot
Copy link
Copy Markdown
Contributor

Started test build 172335

@flathubbot
Copy link
Copy Markdown
Contributor

Build 172335 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/155453/com.makemkv.MakeMKV.flatpakref

@michaelkuhn
Copy link
Copy Markdown
Collaborator

Will users have to move their existing configuration manually in this case? I think that would be a bad user experience.

@nalsai
Copy link
Copy Markdown
Author

nalsai commented Jan 6, 2025

Yes, they would have to move their configuration or set it again.

Considering that there is barely any configuration I think it wouldn't be too much of an issue.
99% percent of users are not going to change anything more than the product key (if you use the beta key you have to update it every couple of months anyway) and maybe lower the minimum title length if you want to also copy tracks shorter than two minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants