Support unsigned 64-bit integers (uint64_t) exceeding INT64_MAX (#501)#513
Open
sndth wants to merge 4 commits intofktn-k:developfrom
Open
Support unsigned 64-bit integers (uint64_t) exceeding INT64_MAX (#501)#513sndth wants to merge 4 commits intofktn-k:developfrom
sndth wants to merge 4 commits intofktn-k:developfrom
Conversation
Large positive decimal scalars whose value exceeds INT64_MAX (e.g. xxHash digests, high-half UUID fields) were silently parsed as STRING nodes instead of INTEGER nodes. Calling as_int() on such a node then threw type_error, making the value unreachable without ugly string post-processing.
…nt_bit-marked nodes
…per to fix MSVC build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Large positive decimal scalars whose value exceeds INT64_MAX (e.g. xxHash digests, high-half UUID fields) were silently parsed as STRING nodes instead of INTEGER nodes. Calling as_int() on such a node then threw type_error, making the value unreachable without ugly string post-processing.
This PR adds transparent uint64_t storage support inside the existing int64_t field via a new style flag, uint_bit, and exposes two new public APIs: is_uint() and as_uint().
Pull Request Checklist
Read the CONTRIBUTING.md file for detailed information.
Please don't
#ifdefs or other means.