You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR fixes an issue with project compilation on GCC compilers.
Looks like the newer GCC versions shows -Werror=deprecated-literal-operator when the project is building.
I prepared a simple fix that check whether compiler is __GNUC__ and the version is newer than 6.
If yes, a new macro - FK_YAML_QUOTE_OPERATOR will use operator""_yaml, otherwise operator"" _yaml.
The documentation is updated if you added/changed a feature.
Please don't
The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
Please do not open pull requests that address multiple issues.
@sndth
Thanks for dealing with this.
Taking a brief look at the changes, I guess you're using different version of clang-format.
Please use the script under scripts directory.
@sndth Thanks for dealing with this. Taking a brief look at the changes, I guess you're using different version of clang-format. Please use the script under scripts directory.
Oh exactly, I am using 20.1.4 but the project is using 18.1.3.
If you want, I can bump version of clang-format, because changes between these versions in case of this project are minimal.
@sndth Thanks for dealing with this. Taking a brief look at the changes, I guess you're using different version of clang-format. Please use the script under scripts directory.
Oh exactly, I am using 20.1.4 but the project is using 18.1.3. If you want, I can bump version of clang-format, because changes between these versions in case of this project are minimal.
Clang-format tools with different major versions would cause a lot of unrelated changes. Although bumping-up is ok, I'd say it's better to do so in a different PR.
Can you use scripts/run_clang_format.(sh|bat) which forces clang-format 18.1.3 for now?
@sndth Thanks for dealing with this. Taking a brief look at the changes, I guess you're using different version of clang-format. Please use the script under scripts directory.
Oh exactly, I am using 20.1.4 but the project is using 18.1.3. If you want, I can bump version of clang-format, because changes between these versions in case of this project are minimal.
Clang-format tools with different major versions would cause a lot of unrelated changes. Although bumping-up is ok, I'd say it's better to do so in a different PR. Can you use scripts/run_clang_format.(sh|bat) which forces clang-format 18.1.3 for now?
Yep! I just dropped commit with formatting changes and there is no files to reformat for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with project compilation on GCC compilers.
Looks like the newer GCC versions shows
-Werror=deprecated-literal-operatorwhen the project is building.I prepared a simple fix that check whether compiler is
__GNUC__and the version is newer than6.If yes, a new macro -
FK_YAML_QUOTE_OPERATORwill useoperator""_yaml, otherwiseoperator"" _yaml.Pull Request Checklist
Read the CONTRIBUTING.md file for detailed information.
Please don't
#ifdefs or other means.