Open
Conversation
hhalex
commented
Jan 22, 2026
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
marvin-j97
reviewed
Jan 23, 2026
src/fs.rs
Outdated
| /// Filesystem abstraction for pluggable storage backends. | ||
| pub trait FileSystem: Send + Sync + std::panic::RefUnwindSafe + std::panic::UnwindSafe { | ||
| /// Opens an existing file for reading. | ||
| fn open(path: &Path) -> io::Result<fs::File>; |
Contributor
There was a problem hiding this comment.
While this trait allows creating a shim file system it still requires "proper" std::fs Files. For like really deterministic simulation testing and what not, File should really be a trait itself. Then the file system and actual files could be fully simulated, kind of like the backend trait in redb, though we have to define more stuff because we have to actually deal with directories.
Author
There was a problem hiding this comment.
Yes totally agree, i am giving a try with another trait for Files. and add it as a type member of the FileSystem trait.
hhalex
commented
Jan 23, 2026
hhalex
force-pushed
the
feat/extract_io_trait
branch
from
177c402 to
ce49061
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.