fix: exclude CPU templates from release tarballs#5911
Open
immanuwell wants to merge 1 commit into
Open
Conversation
Contributor
|
Hi @immanuwell, Thanks for your contribution. I validated your repro and confirmed that the problem exists. I'll take a look into the implementation of the fix soon and get back to you. |
Contributor
Author
|
@JamesC1305 PTAL |
JamesC1305
reviewed
Jun 22, 2026
immanuwell
force-pushed
the
fix-gh-release-cpu-template-tarball
branch
from
June 29, 2026 16:54
5368441 to
403eb9e
Compare
Contributor
Author
|
@JamesC1305 done, addressed all the requested changes, PTAL |
Signed-off-by: immanuwell <pchpr.00@list.ru>
immanuwell
force-pushed
the
fix-gh-release-cpu-template-tarball
branch
from
June 29, 2026 17:02
403eb9e to
cc72a5a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5911 +/- ##
=======================================
Coverage 83.08% 83.08%
=======================================
Files 277 277
Lines 30201 30201
=======================================
Hits 25094 25094
Misses 5107 5107
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
Hey @immanuwell, Looks like style checks are failing due to a missing commit body: https://buildkite.com/firecracker/firecracker-pr/builds/17767/canvas?tab=output&jid=019f5a85-904b-4636-b6a1-bc6ff5c85b35#L150 Could you fix that when you have a chance please? Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Skip release-renamed custom CPU template files when building the GitHub release tarballs.
Reason
release.shcopies templates asC3-$VERSION.json,T2-$VERSION.json, etc.gh_release.pytried to skip templates, but checked only bare names, so the files slipped into the tarball. Small papercut, but real: latestv1.15.1x86_64 tarball has these files inside.Repro:
This adds a regression test and keeps
gh_release.py --helpworking without PyGithub installed, pretty handy for local checks.Tests:
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.