Skip to content

[Firebase AI] Refactor automated test structure#1430

Merged
a-maurice merged 4 commits intomainfrom
am-ai_tests
Apr 17, 2026
Merged

[Firebase AI] Refactor automated test structure#1430
a-maurice merged 4 commits intomainfrom
am-ai_tests

Conversation

@a-maurice
Copy link
Copy Markdown
Collaborator

@a-maurice a-maurice commented Apr 16, 2026

Description

Provide details of the change, and generalize the change in the PR title above.

Rearrange some of the automated tests, to make the more flakey ones just not run on CI. Mostly around tools, and image generation, since those seem more likely to hit limits.


Testing

Describe how you've tested these changes.

https://github.com/firebase/firebase-unity-sdk/actions/runs/24544728621


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the test suite initialization in UIHandlerAutomated.cs by categorizing multi-backend tests into basic, editor-only, and complex groups. This allows for more granular control over test execution based on the environment, such as disabling flakey tests in CI. A review comment correctly identified an incomplete comment on line 175 that should be updated to clearly state that the test selection is based on the environment.

Comment thread firebaseai/testapp/Assets/Firebase/Sample/FirebaseAI/UIHandlerAutomated.cs Outdated
@a-maurice a-maurice requested a review from AustinBenoit April 17, 2026 17:17
@a-maurice a-maurice merged commit 68a767b into main Apr 17, 2026
12 checks passed
@a-maurice a-maurice deleted the am-ai_tests branch April 17, 2026 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants