Fix: remove the Vector SetDefaultEventParameters from being included#1369
Fix: remove the Vector SetDefaultEventParameters from being included#1369AustinBenoit merged 3 commits intomainfrom
Conversation
The documentation is referencing the C++ vector version and it should be removed
Summary of ChangesHello @AustinBenoit, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to refine the auto-generated SDK documentation by explicitly excluding certain C++ Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request aims to prevent SWIG from generating C# wrappers for C++ functions that use std::vector<Parameter>, as these are not intended for direct SDK use. The changes correctly add %ignore directives for the vector-based overloads of LogEvent and SetDefaultEventParameters in the SWIG interface file. The changes look good, but I've suggested a small correction for a typo in a comment to improve clarity and maintain consistency within the file.
The documentation is referencing the C++ vector version and it should be removed.
Description
Ignoring the vector implementation of the SetDefaultEventParameters and the the LogEvent. This should prevent the autogenerate docs from including the random vector types that are not helpful for end SDK users.
Testing
Type of Change
Place an
xthe applicable box: