Update firebase_performance_swizzle_denylist

[tejasd]

Updates usage of firebase_performance_swizzle_denylist to also apply to objects and proxies. Adds relevant unit tests.

This will be followed up with google/GoogleUtilities#244

See - #16469

[gemini-code-assist]

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

[tejasd]

I tested this locally - and noticed that if NSURLConnection is in the denylist - it fails w/ an FPRAssert. Added a second commit that updates that behaviour (which is also identical for UIViewController). Verified that it correctly skips swizzling.

Ideally we should remove swizzling for NSURLConnection - but for now this works.

[tejasd]

/gemini review

[gemini-code-assist]

Code Review

This pull request updates Firebase Performance to honor the swizzle denylist when registering objects, proxies, and classes, and adds corresponding unit tests. Feedback highlights a potential crash in isClassInstrumentable: if aClass is Nil, as passing nil to containsObject: raises an exception, and suggests adding defensive checks.