Skip to content

dataconnect(test): QuerySubscriptionImplUnitTest: fix flaky failures due to incorrect cleanup ordering of flows#8357

Open
dconeybe wants to merge 1 commit into
mainfrom
dconeybe/dataconnect/QuerySubscriptionImplUnitTestCancelInReverseOrder
Open

dataconnect(test): QuerySubscriptionImplUnitTest: fix flaky failures due to incorrect cleanup ordering of flows#8357
dconeybe wants to merge 1 commit into
mainfrom
dconeybe/dataconnect/QuerySubscriptionImplUnitTestCancelInReverseOrder

Conversation

@dconeybe

@dconeybe dconeybe commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

This PR resolves flaky test failures in data connect's QuerySubscriptionImplUnitTest.kt by ensuring that test flow collectors are canceled in the reverse order of their creation. Specifically, clientCollector is now canceled before serverCollector to prevent flaky TurbineAssertionErrors due to unconsumed events.

Highlights

  • Ordered Flow Cancellation: Adjusted cleanup blocks across multiple unit tests to call cancelAndIgnoreRemainingEvents() on clientCollector before serverCollector, matching the reverse order of their creation.
Changelog
  • QuerySubscriptionImplUnitTest.kt
    • Reordered calls to cancelAndIgnoreRemainingEvents() to ensure clientCollector/clientCollectors is canceled before serverCollector.

…s to cancelAndIgnoreRemainingEvents() correctly relative to each other, to ensure that cancellation is done in the reverse order of creation.

This fixes flaky failures like the following:

```
app.cash.turbine.TurbineAssertionError: Unconsumed events found for clientCollector:
 - Complete
	at app.cash.turbine.TurbineAssertionError$Companion.invoke(TurbineAssertionError.kt:32)
```
@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@github-actions

Copy link
Copy Markdown
Contributor

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@dconeybe dconeybe marked this pull request as ready for review June 25, 2026 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant