[AI] expose isThought and thoughtSignature to public#8352
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request exposes the thoughtSignature and isThought properties on various Part implementations by changing thoughtSignature visibility to public and adding static factory create methods to their companion objects. It also fixes a bug in toPublic() where the URI and MIME type arguments for FileDataPart were swapped, and adds corresponding unit tests. The reviewer feedback suggests declaring thoughtSignature directly in the Part interface with a default implementation to allow polymorphic access, and recommends adding unit tests for the remaining Part implementations that received new create factory methods.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces static factory methods (create) for various Part implementations to expose and configure the isThought and thoughtSignature properties. It also makes thoughtSignature a public property on the Part interface and its implementations, fixes a parameter ordering bug in FileDataPart instantiation inside toPublic(), and adds corresponding unit tests. There are no review comments to address.
Added static factory methods
createforPartimplementations to exposethoughtSignatureandisThoughtproperties.