Skip to content

[AI] expose isThought and thoughtSignature to public#8352

Open
milaGGL wants to merge 7 commits into
mainfrom
mila-expose-thought-signature-3
Open

[AI] expose isThought and thoughtSignature to public#8352
milaGGL wants to merge 7 commits into
mainfrom
mila-expose-thought-signature-3

Conversation

@milaGGL

@milaGGL milaGGL commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Added static factory methods create for Part implementations to expose thoughtSignature and isThought properties.

@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@github-actions

Copy link
Copy Markdown
Contributor

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@milaGGL

milaGGL commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request exposes the thoughtSignature and isThought properties on various Part implementations by changing thoughtSignature visibility to public and adding static factory create methods to their companion objects. It also fixes a bug in toPublic() where the URI and MIME type arguments for FileDataPart were swapped, and adds corresponding unit tests. The reviewer feedback suggests declaring thoughtSignature directly in the Part interface with a default implementation to allow polymorphic access, and recommends adding unit tests for the remaining Part implementations that received new create factory methods.

@milaGGL

milaGGL commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces static factory methods (create) for various Part implementations to expose and configure the isThought and thoughtSignature properties. It also makes thoughtSignature a public property on the Part interface and its implementations, fixes a parameter ordering bug in FileDataPart instantiation inside toPublic(), and adds corresponding unit tests. There are no review comments to address.

@milaGGL milaGGL marked this pull request as ready for review June 24, 2026 14:38
@milaGGL milaGGL requested a review from rlazo June 24, 2026 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant