feat: streamline clinic registration intake#1184
Merged
Merged
Conversation
SebastianSchuetze
temporarily deployed
to
admin-e2e-smoke
GitHub Actions
Inactive
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
CI generated Payload types differ between the PR base and head commits on the same runner.
Likely cause flags (inferred, not proven):
- schema/config change:
true - payload dependency change:
false - unknown/other:
false
The snippet below shows the first 3 hunks / 120 lines of the CI-generated diff. Review whether this generator output is expected, then resolve this conversation.
CI-generated payload type diff snippet
--- generated/base/payload-types.ts
+++ generated/head/payload-types.ts
@@ -2177,6 +2177,10 @@
*/
contactPhone?: string | null;
/**
+ * Clinic website or public profile URL
+ */
+ websiteOrPublicProfile?: string | null;
+ /**
* Clinic address
*/
address: {
@@ -2229,6 +2233,13 @@
ip?: string | null;
userAgent?: string | null;
};
+ /**
+ * Privacy notice shown during submission
+ */
+ privacyNotice?: {
+ acknowledgedAt?: string | null;
+ url?: string | null;
+ };
updatedAt: string;
createdAt: string;
}
@@ -3793,6 +3804,7 @@
contactLastName?: T;
contactEmail?: T;
contactPhone?: T;
+ websiteOrPublicProfile?: T;
address?:
| T
| {
Contributor
Contributor
Coverage Report for Storybook Tests
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Contributor
Coverage Report for Integration Tests
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Contributor
Combined Coverage Summary
|
SebastianSchuetze
force-pushed
the
feature/clinic-registration-intake
branch
from
486bf1d to
3f5aa97
Compare
SebastianSchuetze
temporarily deployed
to
admin-e2e-smoke
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clinic registration now captures a leaner first-step lead while preserving the existing
clinicApplicationsintake model.What changed
Website or public profilefield to/register/clinicand removeAdditional Notesfrom the public first-step form.websiteOrPublicProfilein the clinic registration API.websiteOrPublicProfileand system-setprivacyNoticemetadata inclinicApplications.additionalNotesin the collection for compatibility, but stop sending it from the public form.Validation
rtk bash -lc 'PAYLOAD_SECRET=${PAYLOAD_SECRET:-${PAYLOAD_SECRET_KEY:-dev-secret}} pnpm generate'rtk pnpm formatrtk pnpm tests --project=unit tests/unit/components/clinicRegistrationForm.test.tsx tests/unit/api/registerClinic.route.test.tsrtk pnpm tests --project=integration tests/integration/clinicApplications.approval.test.tsrtk pnpm tests --project=storybook src/stories/organisms/Auth/ClinicRegistrationForm.stories.tsxrtk pnpm stories:governance:checkrtk bash -lc 'PLAYWRIGHT_BASE_URL=http://localhost:3000 pnpm exec playwright test tests/e2e/public/auth.registration.public-smoke.spec.ts --config=playwright.config.ts --project public-smoke --grep "clinic registration"'rtk pnpm checkrtk bash -lc 'PAYLOAD_SECRET=${PAYLOAD_SECRET:-${PAYLOAD_SECRET_KEY:-dev-secret}} pnpm build'Screenshots
output/playwright/artifacts/register-clinic-public-profile/register-clinic-clean-desktop.pngoutput/playwright/artifacts/register-clinic-public-profile/register-clinic-clean-375.pngDevelopment
Closes #1183
Refs #1182
Closes findmydoc-platform/management#232