Fix UpdateCommandPaletteSuggestions

[KrisVandermotten]

Resolved / Related Issues

• Closes Bug: Duplicate entries in command list #18395

The new code is much simpler than the old code, more straightforward and more efficient.

Steps used to test these changes

This only fixes the bug mentioned above. It does not attempt to fix any of the other issues in the command palette.

This was tested using the same steps as in #18486, on a machine running in nl-BE. No new issues are introduced compared to main.

[yair100]

Thanks! I'll try to take a look and test these changes sometime this week or next week.

[yair100]

I'm having a hard time testing these changes since I still can't reproduce the issue. @Josh65-2201 did you have any luck on your end?

[Josh65-2201]

Haven't reproduce it, @KrisVandermotten Whats your Files set language, Windows language and keyboard layout? I can only think it would be one of those settings causing it to not be consistent.

[KrisVandermotten]

Whats your Files set language, Windows language and keyboard layout?

Windows language is nl-BE. I don't think keyboard layout can affect the code in question, but it's "Belgian (Period)".

Files is set to use the system language.

[Josh65-2201]

I can reproduce it in 4.1.1, with Files language set to Nederlands (Nederland). It is fixed by this PR

[KrisVandermotten]

Is something blocking this PR from being merged? Can I help?

[yair100]

Is something blocking this PR from being merged? Can I help?

This is on my list of things to look at.