Draft
Conversation
rvagg
reviewed
Sep 11, 2025
| import type { Mk20Deal as Deal, Mk20Products as Products, Mk20PDPV1 as PDPV1, Mk20RetrievalV1 as RetrievalV1, Mk20DataSource, Mk20PieceDataFormat } from '../generated'; | ||
| import { ulid } from 'ulid'; | ||
|
|
||
| namespace StreamingCommP { |
Member
There was a problem hiding this comment.
https://github.com/FilOzone/synapse-sdk/blob/master/src/piece/piece.ts has a working implementation of both commpv2 and a streaming form
https://github.com/FilOzone/synapse-sdk/blob/master/src/test/piecelink.test.ts has some authoritative tests that are consistent with the Go implementation so it can be verified, the zeroPieceCidFixture is pretty old, commpv1 for boundary condition number of zero-filled bytes, we just convert the result to a v2 and have something we can validate against.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TypeScript SDK for Market V2, initially featuring PDPv1.