Fix installation of Mailcatcher using RVM and non-RVM#561
Open
chrispelzer wants to merge 2 commits intofideloper:masterfrom
Open
Fix installation of Mailcatcher using RVM and non-RVM#561chrispelzer wants to merge 2 commits intofideloper:masterfrom
chrispelzer wants to merge 2 commits intofideloper:masterfrom
Conversation
…able and update non-rvm mailcatcher dependency to ruby 2.0.0+
…-ignore-dependencies to override mail 2.6.4 requiring ruby 2.0.0+
vivianspencer
added a commit
to CreationAgency/Vaprobash
that referenced
this pull request
Oct 17, 2016
Merged changes from fideloper#561
Contributor
|
Thanks @chrispelzer, we merged it into whatwedo/Vaprobash! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #560
If you try to install Mailcatcher and you have RVM installed,
$(which rvm)never returns the rvm installation, sourcing /home/vagrant/.profile resets the RVM pathsThe non-RVM version fixes the dependency issue on the mail gem bump from 2.6.3 -> 2.6.4 causing the mime-types to be >= 3.0+ from 2.99.2 which requires ruby 2.0.0, this will now install the dependencies needed for mailcatcher separately to lock in their working ruby < 2.0.0 versions