Add support for PHP mongodb extension#550
Open
hussainweb wants to merge 1 commit intofideloper:masterfrom
hussainweb:php-mongodb
Open
Add support for PHP mongodb extension#550hussainweb wants to merge 1 commit intofideloper:masterfrom hussainweb:php-mongodb
hussainweb wants to merge 1 commit intofideloper:masterfrom
hussainweb:php-mongodb
Conversation
Owner
|
Any reason not to assume people will use the more modern extension and go with that? That'd be my preference for Vaprobash, but I haven't touched Mongo in years. |
Author
|
The modern extension is not backward compatible, AFAIK. If you have an app built with the old extension, you likely want that. Changing the default would count as a breaking change. Also, in contributing doc, you say that this is using semver which would mean changing the default should go to 2.0.0. I thought this would be a good fit even for a minor release and when it's time for 2.0.0, we just change the default or even remove support for old extension. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for the mongodb PHP extension which replaces the old mongo extension. The default is still the old extension which can be changed with a variable.
Again, since the default is the extension which is currently installed, I hope this counts as a minor feature and gets in quickly.