Remove TestMoreHelper workaround #122
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add registry check after each statement in simple labeled blocks (≤3 statements) to handle non-local control flow like 'last SKIP' through function calls. The check: - Only applies to labeled blocks without loop constructs - Checks RuntimeControlFlowRegistry after each statement - Jumps to nextLabel if matching control flow detected - Limited to simple blocks to avoid ASM VerifyError Results: - skip_control_flow.t: all 3 tests pass ✓ - make: BUILD SUCCESSFUL ✓ - Baseline maintained: 66683/66880 tests passing in perl5_t/t/uni/variables.t ✓
Fix last SKIP control flow in scalar context
fglock
force-pushed
the
remove-testmorehelper-workaround
branch
3 times, most recently
from
5b5c05f to
6385caa
Compare
Now that the control flow fix is merged (PR #121), we can remove the TestMoreHelper workaround that was transforming skip() calls at parse time. Changes: - Removed TestMoreHelper.java - Removed TestMoreHelper calls from StatementParser and StatementResolver - Updated Test::More.pm skip() to use 'last SKIP' directly - Removed skip_internal() from Test::More.pm exports - Cleaned up test.pl.patch to remove skip_internal workaround Results: - skip_control_flow.t: all 3 tests pass ✓ - Baseline maintained: 66683/66880 ✓
fglock
force-pushed
the
remove-testmorehelper-workaround
branch
from
6385caa to
dea821d
Compare
fglock
force-pushed
the
master
branch
2 times, most recently
from
97346c2 to
469f6cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the control flow fix is merged (PR #121), we can remove the TestMoreHelper workaround that was transforming
skip()calls at parse time.Changes
skip()now useslast SKIPdirectly instead of callingskip_internal()Results
Dependencies
This PR depends on #121 being merged first, as it relies on the control flow fix to properly handle
last SKIPthrough function calls.