fix(ci): add missing generator property to docs benchmark PostHog events#15080
Merged
Swimburger merged 1 commit intomainfrom Apr 16, 2026
Merged
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
lifanzou
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The PostHog benchmark report tracking generator performance against Square's spec started showing
nullfor the generator field on docs benchmark events.Changes Made
generatorproperty (set to"docs") to the PR docs benchmark PostHog event payload inseed.ymlRoot cause: The "Send PR docs benchmark events to PostHog" step in
seed.yml(thedocs-benchmark-reportjob) constructs ajqpayload but omits thegeneratorproperty entirely. The parallel SDK benchmark step in the same file correctly includesgenerator, and the nightly baseline workflow (benchmark-baseline.yml) also correctly passes"docs"as the generator for docs events. This was simply an omission in this one code path, causing PostHog to receive events with anullgenerator.Testing
benchmark-baseline.yml(line 283)Human Review Checklist
"docs"is the intended generator value (matchesbenchmark-baseline.ymlline 283:send_event "docs" "docs" ...)Link to Devin session: https://app.devin.ai/sessions/bc79e70c60a840fe86f0fc78667ec438
Requested by: @Swimburger