Skip to content

fix(ci): add missing generator property to docs benchmark PostHog events#15080

Merged
Swimburger merged 1 commit intomainfrom
devin/1776315704-fix-null-generator-posthog
Apr 16, 2026
Merged

fix(ci): add missing generator property to docs benchmark PostHog events#15080
Swimburger merged 1 commit intomainfrom
devin/1776315704-fix-null-generator-posthog

Conversation

@Swimburger
Copy link
Copy Markdown
Member

@Swimburger Swimburger commented Apr 16, 2026

Description

The PostHog benchmark report tracking generator performance against Square's spec started showing null for the generator field on docs benchmark events.

Changes Made

  • Added the missing generator property (set to "docs") to the PR docs benchmark PostHog event payload in seed.yml

Root cause: The "Send PR docs benchmark events to PostHog" step in seed.yml (the docs-benchmark-report job) constructs a jq payload but omits the generator property entirely. The parallel SDK benchmark step in the same file correctly includes generator, and the nightly baseline workflow (benchmark-baseline.yml) also correctly passes "docs" as the generator for docs events. This was simply an omission in this one code path, causing PostHog to receive events with a null generator.

Testing

  • Cannot be tested locally — this runs in GitHub Actions and sends events to PostHog
  • Verified the fix is consistent with how the same event is constructed in the SDK benchmark step (lines 1110-1144) and in benchmark-baseline.yml (line 283)

Human Review Checklist

  • Confirm "docs" is the intended generator value (matches benchmark-baseline.yml line 283: send_event "docs" "docs" ...)
  • Verify no other PostHog event payloads in the file have the same omission

Link to Devin session: https://app.devin.ai/sessions/bc79e70c60a840fe86f0fc78667ec438
Requested by: @Swimburger


Open with Devin

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@devin-ai-integration
Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

@Swimburger Swimburger merged commit e146c72 into main Apr 16, 2026
62 of 63 checks passed
@Swimburger Swimburger deleted the devin/1776315704-fix-null-generator-posthog branch April 16, 2026 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants