feat(cli): add fine-grained validation logging to debug.log for fern docs dev #11364
+81
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Catherine Deskur <[email protected]>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
… name property) Co-Authored-By: Catherine Deskur <[email protected]>
…on metrics - Remove PostHog event logging from validateWorkspaces.ts - Add ValidationMetrics interface to validateDocsWorkspaceAndLogIssues.ts - Update validateDocsWorkspaceWithoutExiting to return detailed validation metrics - Enhance DebugLogger.logCliValidation to accept detailed metrics - Update runAppPreviewServer.ts to pass validation metrics to debug logger - Update devDocsWorkspace.ts validateProject callback to return metrics Validation metrics now include: errorCount, warningCount, totalViolationCount, and violationsBySeverity breakdown. These are logged to ~/.fern/logs/debug.log during fern docs dev. Co-Authored-By: Catherine Deskur <[email protected]>
devin-ai-integration
bot
changed the title
Co-Authored-By: Catherine Deskur <[email protected]>
chdeskur
reviewed
Dec 23, 2025
| ); | ||
|
|
||
| // Print the aggregated report (using runTask to get a proper TaskContext) | ||
| // Print the aggregated report(using runTask to get a proper TaskContext) |
Contributor
Author
There was a problem hiding this comment.
Good catch! That was an accidental removal of the space when I was editing nearby code. Fixed in 9ef812a.
Co-Authored-By: Catherine Deskur <[email protected]>
Contributor
|
This PR is stale because it has been open 25 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
github-actions
bot
added
the
Stale
Contributor
|
This PR was closed because it has been inactive for 5 days after being marked stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refs: Slack request from Catherine Deskur
Adds fine-grained validation event logging to the
~/.fern/logs/debug.logfile duringfern docs devto track validation metrics and help improve the validation experience.Link to Devin run: https://app.devin.ai/sessions/73d527a31cf549c08d91bf67b55f8d6d
Requested by: Catherine Deskur ([email protected])
Updates Since Last Revision
Based on feedback, the implementation was changed from PostHog event logging to file-based debug logging:
validateWorkspaces.tsDebugLoggerclassfern checktofern docs devcodepaths onlyChanges Made
ValidationMetricsinterface tovalidateDocsWorkspaceAndLogIssues.tsandrunAppPreviewServer.tsvalidateDocsWorkspaceWithoutExitingto return detailed validation metricsDebugLogger.logCliValidationto accept optional detailed metricsrunAppPreviewServer.tsto pass validation metrics to the debug loggerdevDocsWorkspace.tsvalidateProject callback to return metricserrorCount/warningCount/totalViolationCountsuccess- boolean indicating if validation passedviolationsBySeverity- count of violations grouped by severity (fatal/error/warning)elapsedMillis- validation durationTesting
Human Review Checklist
ValidationMetricsinterface duplication (in two files) is acceptable