#212 Breaking/change default to string() implementation#213
Open
stan-at-work wants to merge 2 commits into
Open
#212 Breaking/change default to string() implementation#213stan-at-work wants to merge 2 commits into
stan-at-work wants to merge 2 commits into
Conversation
…mixin.dart) `return '$runtimeType';` -> `return super.toString();`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #212
Status
READY
Breaking Changes
YES
Description
Change the default toString() implementation in equatable.dart and equatable_mixin.dart.
This changes changes
return '$runtimeType';->return super.toString();Todos
Impact on Existing Codebases
This is a behavioral breaking change for any class that:
EquatableMixin, andtoString()itself, andtoString()from a superclass.Additionally, any class extending
Equatableor mixing inEquatableMixinthat relies on the current'$runtimeType'string format will observe a change toInstance of 'ClassName'. Teams are advised to audit usages of.toString()(including implicit calls via string interpolation orprint) on classes that extend or mix in equatable abstractions.