[CDTOOL-1650] Add support for account and workspace level time series commands#1823
[CDTOOL-1650] Add support for account and workspace level time series commands#1823rcaril wants to merge 5 commits into
Conversation
|
Tests will fail until fastly/go-fastly#828 is released and the repo is bumped accordingly. |
philippschulte
left a comment
There was a problem hiding this comment.
The overall CLI wiring looks good, but I think we should add a non-empty workspace time-series test before merging.
This PR does not actually exercise the new data shape or the table renderer for real workspace time-series rows.
Can we add a non-empty workspace time-series CLI test?
I tried various ways to get data to populate on a service we have that is streaming requests - but was unsuccessful. Let me see if I can do anything else to get data examples. |
Added in ded7d2d. |
philippschulte
left a comment
There was a problem hiding this comment.
Thanks, this addresses my concern.
Let me know if you need another approval after addressing the failed linting and test jobs.
Change summary
This PR adds support for NGWAF Time Series commands.
All Submissions:
New Feature Submissions:
Changes to Core Features:
Notes:
This PR is pending the release of this
go-fastlyfeature.