-
Notifications
You must be signed in to change notification settings - Fork 1
Add a bash script to run some benchmarks on AWS #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- It always produced 'inf' because the range was greater than mt19937_64's limit - It makes more sense to use a logscale to better cover the range of possible floating values: uniform_all -> logspace_all
lemire
reviewed
Jun 25, 2025
lemire
reviewed
Jun 25, 2025
lemire
reviewed
Jun 25, 2025
lemire
reviewed
Jun 25, 2025
lemire
reviewed
Jun 25, 2025
lemire
reviewed
Jun 25, 2025
lemire
reviewed
Jun 25, 2025
lemire
reviewed
Jun 25, 2025
lemire
reviewed
Jun 25, 2025
lemire
approved these changes
Jun 25, 2025
Member
lemire
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work.
My comments are non-blocking, just superficial comments.
Principally, this PR: - makes security_group and ssh_key configurable via env variables - generates them automatically if unspecified - adds some checks and comments - adds x86 instances.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
scripts/aws_tests.bashwhich launches multiple AWS instances, runs the existinggenerate_multiple_tables.pyon each of them, and pull back the generated tables locally.uniform_allgenerator (now calledlogscall_all).