fix: support JSON-with-comments for OpenCode/Claude config and keep provider save on live sync failure#1350
Open
crmmc wants to merge 2 commits intofarion1231:mainfrom
Open
fix: support JSON-with-comments for OpenCode/Claude config and keep provider save on live sync failure#1350crmmc wants to merge 2 commits intofarion1231:mainfrom
crmmc wants to merge 2 commits intofarion1231:mainfrom
Conversation
added 2 commits
March 8, 2026 22:00
Owner
|
Codex Review: Didn't find any major issues. 👍 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
When
opencode.jsonor Claude live config contains comments, strict JSON parsing fails.This could block provider-related save flows (including non-OpenCode providers) because live sync paths also touch OpenCode/Claude config parsing.
What changed
Why this fixes the issue
So users no longer lose save capability in CC Switch due to external live config parse/sync errors.
Validation
pnpm typecheckpnpm format:checkpnpm test:unit(24 files, 167 tests)All passed.
Thanks for the review.