Skip to content

Add case studies for PNG, GIF, and MP3#848

Open
andreas-zeller wants to merge 15 commits into
mainfrom
docs
Open

Add case studies for PNG, GIF, and MP3#848
andreas-zeller wants to merge 15 commits into
mainfrom
docs

Conversation

@andreas-zeller
Copy link
Copy Markdown
Collaborator

This PR fixes a few minor bugs in the documentation and adds new case studies for PNG, GIF, and MP3.

@andreas-zeller andreas-zeller requested a review from joszamama March 2, 2026 19:20
@andreas-zeller andreas-zeller added scope: documentation Improvements or additions to documentation prio: medium Medium priority issue labels Mar 2, 2026
@andreas-zeller andreas-zeller changed the title Docs Add case studies for PNG, GIF, and MP3 Mar 2, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 2, 2026

🐰 Bencher Report

Branchdocs
Testbedubuntu-latest
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
milliseconds (ms)
(Result Δ%)
Upper Boundary
milliseconds (ms)
(Limit %)
tests/test_benchmarks.py::test_generate_with_single_hard_constraint📈 view plot
🚷 view threshold
1,959.50 ms
(+10.98%)Baseline: 1,765.63 ms
2,092.71 ms
(93.63%)
tests/test_benchmarks.py::test_generate_with_single_soft_constraint📈 view plot
🚷 view threshold
58,181.09 ms
(+12.72%)Baseline: 51,617.80 ms
79,456.06 ms
(73.22%)
tests/test_benchmarks.py::test_init_fandango📈 view plot
🚷 view threshold
157.75 ms
(+5.40%)Baseline: 149.67 ms
160.67 ms
(98.18%)
tests/test_benchmarks.py::test_parse_spec📈 view plot
🚷 view threshold
157.17 ms
(+3.06%)Baseline: 152.50 ms
160.00 ms
(98.23%)
🐰 View full continuous benchmarking report in Bencher

@joszamama
Copy link
Copy Markdown
Collaborator

Hi @andreas-zeller, the new GIF grammar is broken:

E       fandango.errors.FandangoValueError: Undefined symbol <LogicalScreenDescriptor> in grammar
E       Other undefined symbols: <Trailer>, <ImageDescriptor>, <ImageData>, <Data_1>, <GraphicControlExtension>, <RGB>, <GifHeader>, <DataSubBlocks_1>

The GIF tests do not pass anymore (grammar cannot be executed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

prio: medium Medium priority issue scope: documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants