fix(cmake): enable webserver deps on macOS (httplib include/link)#3832
Open
yoderme wants to merge 2 commits intofalcosecurity:masterfrom
Open
fix(cmake): enable webserver deps on macOS (httplib include/link)#3832yoderme wants to merge 2 commits intofalcosecurity:masterfrom
yoderme wants to merge 2 commits intofalcosecurity:masterfrom
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: yoderme The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
|
Welcome @yoderme! It looks like this is your first PR to falcosecurity/falco 🎉 |
Root CMake skipped openssl/curl/cpp-httplib and c-ares on APPLE while state.h still included webserver.h on all non-Windows Unix builds, causing missing httplib.h on Darwin. Align userspace/falco targets with those conditions, fix FALCO_INCLUDE_DIRECTORIES typo, and gate CPPHTTPLIB_OPENSSL_SUPPORT with the webserver block. Signed-off-by: Mike Yoder <myoder@roblox.com>
yoderme
force-pushed
the
myoder/fix-build-on-macos
branch
from
36e8e19 to
8dfcb34
Compare
Signed-off-by: Mike Yoder <myoder@roblox.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root CMake skipped openssl/curl/cpp-httplib and c-ares on APPLE while state.h still included webserver.h on all non-Windows Unix builds, causing missing httplib.h on Darwin. Align userspace/falco targets with those conditions, fix FALCO_INCLUDE_DIRECTORIES typo, and gate CPPHTTPLIB_OPENSSL_SUPPORT with the webserver block.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #3831
Special notes for your reviewer:
Does this PR introduce a user-facing change?: