build: enable http_output, webserver, and metrics on macOS and Win#3827
Open
build: enable http_output, webserver, and metrics on macOS and Win#3827
Conversation
The HTTP output, health webserver, and Prometheus metrics were excluded from macOS builds as collateral damage when a Linux-only CMake gate was introduced to handle gRPC/protobuf dependencies (86e7692). Now that gRPC has been dropped (43aaffc), the original reason no longer applies. Widen CMake gates and C++ preprocessor guards from Linux-only to all non-Windows/non-Emscripten platforms. Also remove the dead c-ares dependency, which was only needed by gRPC. Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
|
This PR may bring feature or behavior changes in the Falco engine and may require the engine version to be bumped. Please double check userspace/engine/falco_engine_version.h file. See versioning for FALCO_ENGINE_VERSION. /hold |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ekoops, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…gates Rely solely on MINIMAL_BUILD and EMSCRIPTEN as semantic guards instead of explicit platform checks. MSVC builds are unaffected since CompilerFlags.cmake forces MINIMAL_BUILD=ON, keeping these features disabled. Non-MSVC Windows toolchains (MinGW, clang) can now build with http_output if curl and OpenSSL are available. Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
leogr
changed the title
poiana
added
release-note
and removed
do-not-merge/work-in-progress
do-not-merge/release-note-label-needed
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
/kind feature
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
The HTTP output, health webserver, and Prometheus metrics were excluded from macOS and windows builds as collateral damage when a Linux-only CMake gate was introduced to handle gRPC/protobuf dependencies (86e7692). Now that gRPC has been dropped (43aaffc), the original reason no longer applies.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
/milestone 0.44.0
Does this PR introduce a user-facing change?: