fix(locale): update nl_BE phone number patterns - #3981
Merged
Conversation
✅ Deploy Preview for fakerjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
matthewmayer
requested changes
Aug 5, 2026
matthewmayer
enabled auto-merge
August 5, 2026 09:04
auto-merge was automatically disabled
August 5, 2026 11:29
Head branch was pushed to by a user without write access
ST-DDT
added
p: 1-normal
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #3981 +/- ##
=======================================
Coverage 98.91% 98.91%
=======================================
Files 925 925
Lines 3235 3235
Branches 587 587
=======================================
Hits 3200 3200
Misses 31 31
Partials 4 4 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the nl_BE locale phone number format definitions to better reflect current Belgian numbering, removing deprecated international patterns and adjusting mobile/human formats used by faker.phone.number({ style: ... }).
Changes:
- Simplify
mobileformat to a single04########pattern. - Remove deprecated/short international formats and narrow to
+32########(landline) and+324########(mobile). - Refresh
humanformats to focus on common Belgian0x/0xx ...patterns plus mobile formats.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/locales/nl_BE/phone_number/format/mobile.ts | Simplifies mobile format patterns to a single 04######## definition. |
| src/locales/nl_BE/phone_number/format/international.ts | Removes deprecated international formats and keeps updated +32/+324 patterns. |
| src/locales/nl_BE/phone_number/format/human.ts | Updates human-readable formats toward common Belgian 0x/0xx groupings and trims older patterns. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ST-DDT
approved these changes
Aug 5, 2026
Shinigami92
approved these changes
Aug 5, 2026
ST-DDT
changed the title
matthewmayer
approved these changes
Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed deprecated international Belgian phone numbers
Updated phone number format for: Mobile & Human.