feat(phone): mobile style for phone.number#3583
Open
matthewmayer wants to merge 2 commits intofaker-js:nextfrom
Open
feat(phone): mobile style for phone.number#3583matthewmayer wants to merge 2 commits intofaker-js:nextfrom
matthewmayer wants to merge 2 commits intofaker-js:nextfrom
Conversation
✅ Deploy Preview for fakerjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
matthewmayer
changed the title
matthewmayer
added
c: feature
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #3583 +/- ##
========================================
Coverage 99.97% 99.97%
========================================
Files 2894 2922 +28
Lines 222390 222556 +166
Branches 932 931 -1
========================================
+ Hits 222337 222503 +166
Misses 53 53
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #3582
Note in this initial PR i made the code and test changes, plus migrated over existing data from locales/*/cell_phone - for each locale i manually checked the data formats against wikipedia and updated/simplified where necessary.
Could add additional PRs for other locales later.