Include <cstdint> for uint32_t in numpy_support.h - #1609
Merged
meta-codesync[bot] merged 1 commit intoAug 9, 2026
Conversation
Summary: This diff adds `#include <cstdint>` to `numpy_support.h`. The header declares `load_npy_compressed(const char*, uint32_t, uint32_t)` but relied on `uint32_t` arriving transitively through `<memory>`, `<string>`, or `<vector>` rather than including the standard header that defines it. That transitive path is not guaranteed and is not provided under newer GCC/libstdc++ toolchains, where the translation unit fails to compile with `'uint32_t' has not been declared`. Including `<cstdint>` directly makes the header self-contained and it compiles cleanly across toolchains. Differential Revision: D115313605
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@athmasagar has exported this pull request. If you are a Meta employee, you can view the originating Diff in D115313605. |
meta-codesync
Bot
merged commit Aug 9, 2026
fd6e87f
into
facebookresearch:main
204 of 207 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: This diff adds
#include <cstdint>tonumpy_support.h. The header declaresload_npy_compressed(const char*, uint32_t, uint32_t)but relied onuint32_tarriving transitively through<memory>,<string>, or<vector>rather than including the standard header that defines it. That transitive path is not guaranteed and is not provided under newer GCC/libstdc++ toolchains, where the translation unit fails to compile with'uint32_t' has not been declared. Including<cstdint>directly makes the header self-contained and it compiles cleanly across toolchains.Differential Revision: D115313605