Memory leak fix and cancel connection timeout timer in scheduleCleanup.#525
Open
dumganhar wants to merge 3 commits intofacebookincubator:mainfrom
Open
Memory leak fix and cancel connection timeout timer in scheduleCleanup.#525dumganhar wants to merge 3 commits intofacebookincubator:mainfrom
dumganhar wants to merge 3 commits intofacebookincubator:mainfrom
Conversation
This Pull Request fixes two issues: 1. Uses weak SRWebSocket object in the block of `_readUntilHeaderCompleteWithCallback`. Since consumers has a `_completion` block which will retain SRWebSocket instance, if we uses strong self, cycle reference will occur. To Reproduce this issue, just simply connect an invalid website, e.g. ws:://echo111.websocket111.org111 , set a breakpoint in `SRWebSocket:dealloc`, it will never go there. This bug was found by analyzing 'Allocation List' in the `Instruments` tool of Xcode. 2. Should cancel connection timeout timer in scheduleCleanup method, otherwise, the 'dealloc' method will be invoked only after the time (default: 60s) have come, which may cause memory increase. Since `dispatch_after` could not be cancelled, use `performSelector:withObject:afterDelay` & `cancelPreviousPerformRequestsWithTarget:selector:object` instead.
Author
|
I don't know why travis build was failed. :( |
kervich
approved these changes
Mar 15, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes two issues:
Uses weak SRWebSocket object in the block of
_readUntilHeaderCompleteWithCallback. Since consumers has a_completionblock which will retain SRWebSocket instance, if we uses strong self, cycle reference will occur.To Reproduce this issue, just simply connect an invalid website, e.g. ws:://echo111.websocket111.org111 , set a breakpoint in
SRWebSocket:dealloc, it will never go there. This bug was found by analyzingAllocation Listin theInstrumentstool of Xcode.Should cancel connection timeout timer in scheduleCleanup method, otherwise, the
SRWebSocket:deallocmethod will be invoked only after the time (default: 60s) have come, which may cause memory increase.Since
dispatch_aftercould not be cancelled, useperformSelector:withObject:afterDelay&cancelPreviousPerformRequestsWithTarget:selector:objectinstead.