Open
Conversation
Summary: This diff brings support for constraints on ListVariadics. The constraints that can be specified are the same as for TypeVar, that is, Bounds and Explicits. Although ListVariadics currently could infer the bounds based on other values of the concatenation, this approach is too limited. While Pyre had already internal support to express that a ListVariadic has constraints, all the logic related with it was empty, since it was not allow to directly specify the constraint of a ListVariadic. For that purpose, this diff defines the required logic, mostly the propagation of constraints to ensure that violation of constraints are identified, as well as subtyping between the various combinations of variadics. Since subtyping of variables can be ambiguous, we support every case except when given something reduced to `[...,A,Ts1] <: [Ts2,B,...]`. Finally, since parse_declaration does not have access to create_logic, currently only primitive types can be used as constraints, for that purpose a follow up diff is proposed. See comment: https://www.internalfb.com/intern/diff/D23342739/?dest_fbid=606703123545772&transaction_id=343730890366364 Differential Revision: D23342739 fbshipit-source-id: 8b6848fdfcfc6d29be5be0970d1b2a58ad24b13e
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D23342739 |
Contributor
|
Hi @fylux! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but we do not have a signature on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This diff brings support for constraints on ListVariadics. The constraints that can be specified are the same as for TypeVar, that is, Bounds and Explicits. Although ListVariadics currently could infer the bounds based on other values of the concatenation, this approach is too limited.
While Pyre had already internal support to express that a ListVariadic has constraints, all the logic related with it was empty, since it was not allow to directly specify the constraint of a ListVariadic. For that purpose, this diff defines the required logic, mostly the propagation of constraints to ensure that violation of constraints are identified, as well as subtyping between the various combinations of variadics.
Since subtyping of variables can be ambiguous, we support every case except when given something reduced to
[...,A,Ts1] <: [Ts2,B,...].Finally, since parse_declaration does not have access to create_logic, currently only primitive types can be used as constraints, for that purpose a follow up diff is proposed. See comment: https://www.internalfb.com/intern/diff/D23342739/?dest_fbid=606703123545772&transaction_id=343730890366364
Differential Revision: D23342739