Wire up autocomplete tests for OSS - #9773
Closed
mszabo-wikia wants to merge 1 commit into
Closed
Conversation
Build `hh_single_complete` via Dune, and use an explicit enum format method in lieu of an FB-specific migration helper for parse_errors.py. Add a helper script that takes care of invoking Dune with the correct environment variables setup so that e.g. `_build/hphp/hack/hack_oss_dune_invoke.sh build @autocomplete` can be used to run autocomplete tests.
Contributor
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D102800630. (Because this pull request was imported automatically, there will not be any future comments.) |
Contributor
|
Seems reasonable, could you rebase this one too? |
Contributor
Author
|
I might open a new one for this - I have a fairly extensive build system patch pending following the refactoring in c5f58c1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build
hh_single_completevia Dune, and use an explicit enum format method in lieu of an FB-specific migration helper for parse_errors.py. Add a helper script that takes care of invoking Dune with the correct environment variables setup so that e.g._build/hphp/hack/hack_oss_dune_invoke.sh build @autocompletecan be used to run autocomplete tests.