vasm-graph-color: split penalty vectors when consensus conflicts - #9686
Closed
igogo-x86 wants to merge 1 commit into
Closed
vasm-graph-color: split penalty vectors when consensus conflicts#9686igogo-x86 wants to merge 1 commit into
igogo-x86 wants to merge 1 commit into
Conversation
color_block_initialize() biases each live-in toward the phys reg that its processed predecessors already use by adding weight to every *other* phys reg in the shared penalty vector. When multiple live-ins reuse that vector but their predecessors chose different phys regs, those penalties contradict each other. The resulting vector no longer corresponds to any of the prior assignments, so the allocator picks a register based on whatever mix of penalties remains, and we emit edge copies to fix the mismatches (while also pushing the wrong hint backward). Detect conflicting consensus assignments and clone the penalty vector on the spot so each live-in keeps its own bias/undo bookkeeping.
Contributor
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D88480438. (Because this pull request was imported automatically, there will not be any future comments.) |
|
Thanks again for the PR! This one triggers an assertion We also get SIGABRT crashes (e.g |
Contributor
Author
|
That assert shows some problems with the patch that are quite difficult to fix. Let's try a different approach - #9696 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
color_block_initialize() biases each live-in toward the phys reg that its processed predecessors already use by adding weight to every other phys reg in the shared penalty vector. When multiple live-ins reuse that vector but their predecessors chose different phys regs, those penalties contradict each other. The resulting vector no longer corresponds to any of the prior assignments, so the allocator picks a register based on whatever mix of penalties remains, and we emit edge copies to fix the mismatches (while also pushing the wrong hint backward).
Detect conflicting consensus assignments and clone the penalty vector on the spot so each live-in keeps its own bias/undo bookkeeping.